New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host groups by custom attributes #27223

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@kevein

kevein commented Jul 24, 2017

SUMMARY

This patch is designated to integrate with CloudForms automation process. Instead of using Tags, custom attribute is more flexible to use. It's better to use custom attribtes while creating host groups in automation process.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

contrib/inventory/cloudforms.py

ANSIBLE VERSION
# ansible --version
ansible 2.2.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

ADDITIONAL INFORMATION

kevein added some commits Feb 23, 2017

This patch is designated to integrate with CloudForms automation proc…
…ess. Instead of using Tags, custom attribute is more flexible to use.

It's better to use custom attribtes while creating host groups in
automation process.
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 24, 2017

The test ansible-test sanity --test pep8 failed with the following error:

contrib/inventory/cloudforms.py:264:161: E501 line too long (174 > 160 characters)

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 21, 2017

@kevein this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 21, 2017

The test ansible-test compile --python 2.6 failed with the following error:

contrib/inventory/cloudforms.py:265:60: SyntaxError: self.cloudforms_url, offset, limit))

The test ansible-test compile --python 3.5 failed with the following error:

contrib/inventory/cloudforms.py:265:60: SyntaxError: self.cloudforms_url, offset, limit))

The test ansible-test compile --python 2.7 failed with the following error:

contrib/inventory/cloudforms.py:265:60: SyntaxError: self.cloudforms_url, offset, limit))

The test ansible-test compile --python 3.6 failed with the following error:

contrib/inventory/cloudforms.py:265:60: SyntaxError: self.cloudforms_url, offset, limit))

The test ansible-test sanity --test pep8 failed with the following errors:

contrib/inventory/cloudforms.py:264:137: W291 trailing whitespace
contrib/inventory/cloudforms.py:265:25: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:266:13: E122 continuation line missing indentation or outdented
contrib/inventory/cloudforms.py:267:13: E122 continuation line missing indentation or outdented
contrib/inventory/cloudforms.py:268:26: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:268:28: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:269:13: E122 continuation line missing indentation or outdented
contrib/inventory/cloudforms.py:271:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:273:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:274:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:277:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:277:20: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:277:22: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:278:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:278:19: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:278:21: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:280:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:283:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:299:43: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:299:45: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:299:59: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:299:68: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:299:78: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:305:33: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:305:35: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:320:41: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:320:43: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:322:38: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:322:40: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:331:42: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:331:44: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:337:62: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:337:64: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:337:78: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:337:87: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:337:97: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:348:49: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:348:51: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:357:56: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:357:58: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:357:72: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:357:81: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:357:91: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:361:29: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:361:31: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:376:41: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:376:43: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:380:25: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:380:27: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:384:40: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:384:42: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:384:56: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:384:65: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:384:75: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:388:45: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:388:47: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:388:61: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:388:70: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:388:80: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:398:37: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:398:39: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:401:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:404:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:405:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:407:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:408:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:411:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:415:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:428:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:430:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:431:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:434:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:436:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:437:17: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:437:19: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:439:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:440:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:443:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:443:14: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:443:16: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:444:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:444:23: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:444:25: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:445:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:445:23: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:445:25: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:447:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:448:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:451:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:451:14: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:451:16: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:452:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:452:19: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:452:21: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:453:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:453:19: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:453:21: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:455:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:456:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:459:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:459:18: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:459:20: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:460:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:460:14: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:460:16: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:461:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:462:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:464:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:465:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:468:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:469:18: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:469:20: E251 unexpected spaces around keyword / parameter equals
contrib/inventory/cloudforms.py:471:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:474:5: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:474:44: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:475:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:478:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:479:46: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:479:59: E225 missing whitespace around operator
contrib/inventory/cloudforms.py:480:9: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:483:1: E128 continuation line under-indented for visual indent
contrib/inventory/cloudforms.py:484:1: E901 TokenError: EOF in multi-line statement

The test ansible-test sanity --test pylint failed with the following error:

contrib/inventory/cloudforms.py:265:0: syntax-error invalid syntax

click here for bot help

@ansibot ansibot added the ci_verified label Aug 21, 2017

@ansibot ansibot removed the ci_verified label Aug 25, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 25, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

contrib/inventory/cloudforms.py:264:137: W291 trailing whitespace
contrib/inventory/cloudforms.py:265:25: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2017

@kevein this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

contrib/inventory/cloudforms.py:264:137: W291 trailing whitespace
contrib/inventory/cloudforms.py:265:25: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test pylint [?] failed with the following error:

contrib/inventory/cloudforms.py:264:0: trailing-whitespace Trailing whitespace

click here for bot help

@samdoran

This comment has been minimized.

Member

samdoran commented Jun 23, 2018

bot_skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment