Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to trust CA certs for java_cert module #27431

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
7 participants
@jagibson
Copy link
Contributor

commented Jul 28, 2017

SUMMARY

This will tell the java keytool command to import the cert as a trusted CA.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

java_cert module

ANSIBLE VERSION
ansible 2.3.1.0
  config file = 
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]
ADDITIONAL INFORMATION

Useful for:

  • adding an internal CA for your organization.
  • adding new vendor CA certs

@s-hertel s-hertel removed the needs_triage label Jul 28, 2017

@alikins alikins changed the title Add ability to trust CA certs Add ability to trust CA certs for java_cert module Jul 31, 2017

@ansibot ansibot added the stale_ci label Aug 6, 2017

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2017

@haad

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2017

lgtm shipit

@mutyonok

This comment has been minimized.

Copy link

commented Oct 27, 2017

any plans on merging it?

@jagibson

This comment has been minimized.

Copy link
Contributor Author

commented Dec 6, 2017

Looks like upstream has changed since I created this PR. Do I need to fix it of is that up to someone else?

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

@jagibson You'll need to fix it up. You'll need to fetch upstream and rebase, and fix up any merge conflicts, then push a revision. Target version will be 2.5 now as well so I suggest changing that at the same time.

@bgiorgini

This comment has been minimized.

Copy link

commented Nov 14, 2018

We need this support for trusted_ca is there any maintainer merging this?

@bgiorgini

This comment has been minimized.

Copy link

commented Nov 14, 2018

We need this support for trusted_ca is there any maintainer merging this?

@jagibson are you merging this?

@jagibson

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

@bgiorgini Upstream has changed so much since my original PR I haven't bothered. If you'd like it to give it a shot go for it. Otherwise it's on my "when I have extra time" plate.

@ansibot ansibot added the needs_repo label Dec 11, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2018

@jagibson Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.