New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urldecode and urlencode filters for Jinja2 #28503

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@dagwieers
Member

dagwieers commented Aug 22, 2017

SUMMARY

We needed this in order to construct correct URLs using Jinja2.
And we might as well upstream this.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

urls filters

ANSIBLE VERSION

v2.4

Dag Wieers
urldecode and urlencode filters for Jinja2
We needed this in order to construct correct URLs using Jinja2.
And we might as well upstream this.
@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 22, 2017

The test ansible-test sanity --test boilerplate failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/plugins/filter/urls.py

click here for bot help

@sivel

This comment has been minimized.

Member

sivel commented Aug 22, 2017

urlencode is already a core filter of jinja2 and should likely not be added to ansible.

http://jinja.pocoo.org/docs/dev/templates/#urlencode

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 22, 2017

The test ansible-test sanity --test boilerplate failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/plugins/filter/urls.py

click here for bot help

@bcoca

This comment has been minimized.

Member

bcoca commented Nov 30, 2018

@dagwieers do you want to resubmit just urldecode? diff filters? tests/docs would also be nice in that case

needs_info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment