New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messaging: Add new modules for kafka-configs #29009

Open
wants to merge 13 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@gdelpierre
Contributor

gdelpierre commented Sep 5, 2017

SUMMARY

This module aims to allow a user to manage Kafka configs

Internally it relies on kafka scripts (kafka-configs.sh).

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • kafka_configs.py
ANSIBLE VERSION
ansible 2.3.1.0
  config file = /home/gdelpierre/devel/roles/ansible.cfg
  configured module search path = [u'./library/']
  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]
@gdelpierre

This comment has been minimized.

Contributor

gdelpierre commented Sep 5, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 5, 2017

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/messaging/kafka_configs.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/messaging/kafka_configs.py

The test ansible-test sanity --test no-dict-iteritems [?] failed with the following error:

Command "test/sanity/code-smell/no-dict-iteritems.sh" returned exit status 1.
>>> Standard Output
iteritems has been removed in python3.  Alternatives:
    for KEY, VALUE in DICT.items():
    from ansible.module_utils.six import iteritems ; for KEY, VALUE in iteritems(DICT):
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k,v in entity.iteritems() if v)
./lib/ansible/modules/messaging/kafka_configs.py:            for k,v in self.add_configs.iteritems():
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k,v in entity.iteritems() if v)

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:112:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:115:1: W293 blank line contains whitespace
lib/ansible/modules/messaging/kafka_configs.py:116:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:126:23: E221 multiple spaces before operator
lib/ansible/modules/messaging/kafka_configs.py:138:1: W293 blank line contains whitespace
lib/ansible/modules/messaging/kafka_configs.py:140:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/messaging/kafka_configs.py:144:54: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:148:18: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:160:21: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:161:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:162:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:163:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:166:21: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:167:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:168:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:169:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:177:24: E201 whitespace after '{'
lib/ansible/modules/messaging/kafka_configs.py:177:53: E202 whitespace before '}'
lib/ansible/modules/messaging/kafka_configs.py:188:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/messaging/kafka_configs.py:192:54: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:204:24: E713 test for membership should be 'not in'
lib/ansible/modules/messaging/kafka_configs.py:219:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:229:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:229:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:230:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:230:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:233:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:233:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:237:5: E303 too many blank lines (2)
lib/ansible/modules/messaging/kafka_configs.py:252:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:252:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:253:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:253:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:254:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:254:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:255:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:255:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:256:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:256:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:259:62: E502 the backslash is redundant between brackets
lib/ansible/modules/messaging/kafka_configs.py:260:21: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/messaging/kafka_configs.py:217:12: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.add_configs.type: not a valid value for dictionary value @ data['options']['add_configs']['type']. Got 'dict'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.del_configs.type: not a valid value for dictionary value @ data['options']['del_configs']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_default.type: not a valid value for dictionary value @ data['options']['entity_default']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_name.type: not a valid value for dictionary value @ data['options']['entity_name']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_type.type: not a valid value for dictionary value @ data['options']['entity_type']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.jaas_auth_file.type: not a valid value for dictionary value @ data['options']['jaas_auth_file']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.kafka_path.type: not a valid value for dictionary value @ data['options']['kafka_path']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.pretty.required: expected bool for dictionary value @ data['options']['pretty']['required']. Got None
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.zookeeper.type: not a valid value for dictionary value @ data['options']['zookeeper']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E307 version_added should be 2.4. Currently 2.5

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 5, 2017

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/messaging/kafka_configs.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/messaging/kafka_configs.py

The test ansible-test sanity --test no-dict-iteritems [?] failed with the following error:

Command "test/sanity/code-smell/no-dict-iteritems.sh" returned exit status 1.
>>> Standard Output
iteritems has been removed in python3.  Alternatives:
    for KEY, VALUE in DICT.items():
    from ansible.module_utils.six import iteritems ; for KEY, VALUE in iteritems(DICT):
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k,v in entity.iteritems() if v)
./lib/ansible/modules/messaging/kafka_configs.py:            for k,v in self.add_configs.iteritems():
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k,v in entity.iteritems() if v)

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:112:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:115:1: W293 blank line contains whitespace
lib/ansible/modules/messaging/kafka_configs.py:116:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:126:23: E221 multiple spaces before operator
lib/ansible/modules/messaging/kafka_configs.py:138:1: W293 blank line contains whitespace
lib/ansible/modules/messaging/kafka_configs.py:140:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/messaging/kafka_configs.py:144:54: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:148:18: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:160:21: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:161:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:162:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:163:45: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:166:21: E127 continuation line over-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:167:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:168:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:169:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:177:24: E201 whitespace after '{'
lib/ansible/modules/messaging/kafka_configs.py:177:53: E202 whitespace before '}'
lib/ansible/modules/messaging/kafka_configs.py:188:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/messaging/kafka_configs.py:192:54: E231 missing whitespace after ','
lib/ansible/modules/messaging/kafka_configs.py:204:24: E713 test for membership should be 'not in'
lib/ansible/modules/messaging/kafka_configs.py:219:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:229:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:229:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:230:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:230:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:233:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:233:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:237:5: E303 too many blank lines (2)
lib/ansible/modules/messaging/kafka_configs.py:252:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:252:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:253:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:253:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:254:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:254:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:255:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:255:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:256:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:256:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/messaging/kafka_configs.py:259:62: E502 the backslash is redundant between brackets
lib/ansible/modules/messaging/kafka_configs.py:260:21: E128 continuation line under-indented for visual indent

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/messaging/kafka_configs.py:217:12: undefined-variable Undefined variable 'module'

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.add_configs.type: not a valid value for dictionary value @ data['options']['add_configs']['type']. Got 'dict'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.del_configs.type: not a valid value for dictionary value @ data['options']['del_configs']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_default.type: not a valid value for dictionary value @ data['options']['entity_default']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_name.type: not a valid value for dictionary value @ data['options']['entity_name']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_type.type: not a valid value for dictionary value @ data['options']['entity_type']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.jaas_auth_file.type: not a valid value for dictionary value @ data['options']['jaas_auth_file']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.kafka_path.type: not a valid value for dictionary value @ data['options']['kafka_path']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.pretty.required: expected bool for dictionary value @ data['options']['pretty']['required']. Got None
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.zookeeper.type: not a valid value for dictionary value @ data['options']['zookeeper']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E307 version_added should be 2.4. Currently 2.5

click here for bot help

Fix ansibot review
[module] PEP8
[module] boilerplate

@samdoran samdoran removed the needs_triage label Sep 5, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 5, 2017

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc kafka_configs" returned exit status 1.
>>> Standard Error
ERROR! module kafka_configs missing documentation (or could not parse documentation): Incorrect value for 'Required', a boolean is needed.: None

The test ansible-test sanity --test no-dict-iteritems [?] failed with the following error:

Command "test/sanity/code-smell/no-dict-iteritems.sh" returned exit status 1.
>>> Standard Output
iteritems has been removed in python3.  Alternatives:
    for KEY, VALUE in DICT.items():
    from ansible.module_utils.six import iteritems ; for KEY, VALUE in iteritems(DICT):
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k, v in entity.iteritems() if v)
./lib/ansible/modules/messaging/kafka_configs.py:            for k, v in self.add_configs.iteritems():
./lib/ansible/modules/messaging/kafka_configs.py:        entity_join = ''.join(" %s %r" % (k, v) for k, v in entity.iteritems() if v)

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:118:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:133:23: E221 multiple spaces before operator
lib/ansible/modules/messaging/kafka_configs.py:147:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/messaging/kafka_configs.py:211:24: E713 test for membership should be 'not in'

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.add_configs.type: not a valid value for dictionary value @ data['options']['add_configs']['type']. Got 'dict'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.del_configs.type: not a valid value for dictionary value @ data['options']['del_configs']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_default.type: not a valid value for dictionary value @ data['options']['entity_default']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_name.type: not a valid value for dictionary value @ data['options']['entity_name']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_type.type: not a valid value for dictionary value @ data['options']['entity_type']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.jaas_auth_file.type: not a valid value for dictionary value @ data['options']['jaas_auth_file']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.kafka_path.type: not a valid value for dictionary value @ data['options']['kafka_path']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.pretty.required: expected bool for dictionary value @ data['options']['pretty']['required']. Got None
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.zookeeper.type: not a valid value for dictionary value @ data['options']['zookeeper']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E307 version_added should be 2.4. Currently 2.5

click here for bot help

@mattclay mattclay added the ci_verified label Sep 5, 2017

@gdelpierre

This comment has been minimized.

Contributor

gdelpierre commented Sep 6, 2017

@jwoodrich I've changed the way to deal with configs according to your feedback on #27323 .
Could you test it ?

@ansibot ansibot removed the ci_verified label Sep 6, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 6, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:102:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/messaging/kafka_configs.py:167:44: W601 .has_key() is deprecated, use 'in'
lib/ansible/modules/messaging/kafka_configs.py:176:40: W601 .has_key() is deprecated, use 'in'
lib/ansible/modules/messaging/kafka_configs.py:188:24: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:194:24: E128 continuation line under-indented for visual indent
lib/ansible/modules/messaging/kafka_configs.py:223:13: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.configs.type: not a valid value for dictionary value @ data['options']['configs']['type']. Got 'dict'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_default.type: not a valid value for dictionary value @ data['options']['entity_default']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_name.type: not a valid value for dictionary value @ data['options']['entity_name']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.entity_type.type: not a valid value for dictionary value @ data['options']['entity_type']['type']. Got 'str'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.jaas_auth_file.type: not a valid value for dictionary value @ data['options']['jaas_auth_file']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.kafka_path.type: not a valid value for dictionary value @ data['options']['kafka_path']['type']. Got 'path'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E305 DOCUMENTATION.options.zookeeper.type: not a valid value for dictionary value @ data['options']['zookeeper']['type']. Got 'list'
lib/ansible/modules/messaging/kafka_configs.py:0:0: E307 version_added should be 2.4. Currently 2.5

click here for bot help

@ansibot ansibot added the ci_verified label Sep 6, 2017

PEP8 + documentation
[module] PEP8
[documentation] Add return and correct documentation schema

@ansibot ansibot removed the ci_verified label Sep 7, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 7, 2017

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/messaging/kafka_configs.py:99:161: E501 line too long (208 > 160 characters)

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/messaging/kafka_configs.py:100:13: E313 RETURN is not valid YAML
lib/ansible/modules/messaging/kafka_configs.py:102:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/messaging/kafka_configs.py:103:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 7, 2017

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/messaging/kafka_configs.py:102:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified label Sep 7, 2017

@ansibot ansibot removed the ci_verified label Sep 7, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 7, 2017

@chrishoffman @hyperized @manuel-sousa @retr0h @romanek-adam

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Rewrite some part
[module]
 * remove pretty output
 * remove jaas configuration
 * refactoring

@ansibot ansibot removed the stale_ci label Sep 19, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 19, 2017

The test ansible-test compile --python 2.6 [?] failed with the following error:

test/units/modules/messaging/test_kafka.py:119:80: SyntaxError: mock_run_command.assert_called_once_with('/usr/bin/kafka-configs --alter

The test ansible-test compile --python 2.7 [?] failed with the following error:

test/units/modules/messaging/test_kafka.py:119:80: SyntaxError: mock_run_command.assert_called_once_with('/usr/bin/kafka-configs --alter

The test ansible-test compile --python 3.6 [?] failed with the following error:

test/units/modules/messaging/test_kafka.py:119:81: SyntaxError: mock_run_command.assert_called_once_with('/usr/bin/kafka-configs --alter

The test ansible-test compile --python 3.5 [?] failed with the following error:

test/units/modules/messaging/test_kafka.py:119:81: SyntaxError: mock_run_command.assert_called_once_with('/usr/bin/kafka-configs --alter

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/units/modules/messaging/test_kafka.py:60:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:60:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:60:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:61:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:76:161: E501 line too long (165 > 160 characters)
test/units/modules/messaging/test_kafka.py:81:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:81:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:81:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:82:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:104:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:104:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:104:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:105:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:119:52: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:119:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:119:59: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:119:65: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:119:75: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:120:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:120:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:120:79: E231 missing whitespace after ':'
test/units/modules/messaging/test_kafka.py:121:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:121:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:121:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:122:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:122:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:122:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:123:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:123:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:123:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:129:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:129:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:129:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:130:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:144:52: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:144:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:144:59: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:144:65: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:144:75: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:145:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:145:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:145:79: E231 missing whitespace after ':'
test/units/modules/messaging/test_kafka.py:146:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:146:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:146:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:147:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:147:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:147:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:148:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:148:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:148:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:154:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:154:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:154:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:155:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:169:52: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:169:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:169:59: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:169:65: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:169:75: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:170:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:170:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:170:79: E231 missing whitespace after ':'
test/units/modules/messaging/test_kafka.py:171:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:171:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:171:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:172:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:172:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:172:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:173:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:173:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:173:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:181:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:181:1: W191 indentation contains tabs
test/units/modules/messaging/test_kafka.py:181:4: E131 continuation line unaligned for hanging indent
test/units/modules/messaging/test_kafka.py:182:1: E101 indentation contains mixed spaces and tabs
test/units/modules/messaging/test_kafka.py:196:52: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:196:55: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:196:59: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:196:65: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:196:75: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:197:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:197:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:197:79: E231 missing whitespace after ':'
test/units/modules/messaging/test_kafka.py:198:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:198:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:198:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:199:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:199:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:199:58: E226 missing whitespace around arithmetic operator
test/units/modules/messaging/test_kafka.py:200:50: W503 line break before binary operator
test/units/modules/messaging/test_kafka.py:200:51: E225 missing whitespace around operator
test/units/modules/messaging/test_kafka.py:200:58: E226 missing whitespace around arithmetic operator

The test ansible-test sanity --test pylint [?] failed with the following error:

test/units/modules/messaging/test_kafka.py:119:0: syntax-error EOL while scanning string literal

click here for bot help

gdelpierre added some commits Sep 19, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Sep 19, 2017

'''
EXAMPLES = '''
name: 'list config'

This comment has been minimized.

@gundalow

gundalow Dec 7, 2018

Contributor
Suggested change Beta
name: 'list config'
- name: 'list config'

Same for others. You will need to check indentation

@ansibot ansibot added the support:core label Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment