New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mdd rds split instance 2 #29032

Open
wants to merge 58 commits into
base: devel
from

Conversation

@mikedlr
Contributor

mikedlr commented Sep 6, 2017

SUMMARY

This PR contains version 2 of a new rds_instance module. Compared to PR #26602 it is simplified, has a more standard AWS set of module parameters and simplified parameter handling code. However it doesn't fully work yet.

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.4.0 (mdd_rds_split_instance b81ee48144) last updated 2017/07/10 15:03:32 (GMT +100)
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/mikedd/dev/ansible/ansible-add-modules/library']
  ansible python module location = /home/mikedd/dev/ansible/ansible-add-modules/lib/ansible
  executable location = /home/mikedd/dev/ansible/ansible-add-modules/bin/ansible
  python version = 3.5.2 (default, Nov 17 2016, 17:05:23) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

This is a much updated version of #19772 from Willthames which contains fixes interface and code changes

An earlier version of this is preserved in #26602 before the major interface changes begin. If having problems converting from one to the other the #ansible-aws channel on IRC is the best way to reach me (also as mikedlr)

Split the existing rds module into three separate modules, and make the modules idempotent (remove the command argument).
Redo the handling of parameters moving to match the parameter names in the AWS API and only provide short aliases in a few cases
The new modules are entirely boto3 - support for boto has been dropped for the new modules.

There are integration tests in a separate PR.

KNOWN ISSUES
  • This has not been tested for working with all states of the RDS - #19751 might apply equally here - the situation is likely better than existing RDS modules and retry will work once the RDS has stabilised
@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 6, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 6, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 6, 2017

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:77:161: E501 line too long (217 > 160 characters)

click here for bot help

@mikedlr mikedlr force-pushed the mikedlr:mdd_rds_split_instance_2 branch from 36a858b to d6b5c33 Sep 21, 2017

@ansibot ansibot removed the stale_ci label Sep 21, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 21, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/units/modules/cloud/amazon/test_rds.py:422:38: E225 missing whitespace around operator
test/units/modules/cloud/amazon/test_rds.py:422:82: W291 trailing whitespace

The test ansible-test sanity --test pylint [?] failed with the following error:

test/units/modules/cloud/amazon/test_rds.py:422:0: trailing-whitespace Trailing whitespace

click here for bot help

@ansibot ansibot added the stale_ci label Sep 29, 2017

@s-hertel s-hertel added this to In Progress in 2.5 Oct 2, 2017

@gundalow gundalow added test and removed test labels Oct 17, 2017

@willthames

This comment has been minimized.

Contributor

willthames commented Oct 20, 2017

Can we clean up all these pull requests so that it's clear which one we should be working on?

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 18, 2018

Thanks @mikedlr! This PR was evaluated as a bad PR for the following reasons:

  • More than 50 commits.

Such PR can only be merged by human, contact core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment