Feature/test inventory

[4383]

SUMMARY

Adding unit test for yaml inventory plugin related to #30663

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

test/units/plugins/inventory/test_inventory.py

ANSIBLE VERSION

ansible 2.5.0 (feature/test-inventory d730b962a0) last updated 2017/09/21 16:51:18 (GMT +200)
  config file = None
  configured module search path = ['/home/herve/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/herve/dev/ansible/lib/ansible
  executable location = /home/herve/dev/ansible/bin/ansible
  python version = 3.5.2 (default, Nov 17 2016, 17:05:23) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

After change

$ pytest -s -v test/units/plugins/inventory/test_inventory.py::IniInventory::test_yaml_inventory
============================================================= test session starts =============================================================
platform linux -- Python 3.5.2, pytest-3.2.2, py-1.4.34, pluggy-0.4.0 -- /home/herve/dev/ansible/venv/bin/python3.5
cachedir: .cache
rootdir: /home/herve/dev/ansible, inifile:
plugins: xdist-1.20.0, f5-sdk-3.0.1, forked-0.2, mock-1.6.3
collected 1 item                                                                                                                               

test/units/plugins/inventory/test_inventory.py::IniInventory::test_yaml_inventory PASSED

========================================================== 1 passed in 0.57 seconds ===========================================================

[bcoca]

i actually added a yaml inventory file to testing so we could use it to run the other tests (uses ini now, but could split the load) .. but it got moved to legacy :-(

[pilou-]

textwrap.dedent could be used here.

[mattclay]

The unit test should be self-contained, so having it provide its own inventory is good.

[bcoca]

not an 'either/or' ... part of testing the plugin is seeing that the verify_file method works.

[mattclay]

Using files in unit tests is fine. However, those files should be stored alongside the unit tests instead of shared with integration tests. Mixing the two complicates dependency analysis when looking at changes to determine which tests to execute.

[4383]

@pilou- improved code

[4383]

@pilou- C.INVENTORY_ENABLED must be reset after using?

[pilou-]

Yes. The new method is inside IniInventory class, it could be moved in another class (YamlInventory ?), then setUp and tearDown methods could be used in order to 1. save, 2. set (in setUp) and 3. restore (in tearDown) C.INVENTORY_ENABLED.

[bcoca]

@mattclay good point, i was trying to leverage the file but it does make cross dependencies that I didn't realize

[4383]

Applied

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following error:

test/units/plugins/inventory/test_inventory.py:165:38: E231 missing whitespace after ','

click here for bot help

[pilou-]

Looks good to me

[bcoca]

code lgtm, reorg .. i'll let @mattclay decide