New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/TEST] Mdd rds split testing wip - demo branch for future RDS #30746

Open
wants to merge 172 commits into
base: devel
from

Conversation

@mikedlr
Contributor

mikedlr commented Sep 22, 2017

SUMMARY

Due to the requirement for a PR to only contain a single module, each of the new modules for RDS is in a separate PR, however they need to be tested together. This is a branch which has all those PRs merged (yes - git merged - this branch should ever go back to devel) into one.

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

rds various

ANSIBLE VERSION
ansible 2.5.0 (mdd_rds_split_testing_wip bde482f5bf) last updated 2017/09/22 11:43:04 (GMT +100)
  config file = None
  configured module search path = [u'/home/mikedlr/dev/ansible/ansible-dev/library']
  ansible python module location = /home/mikedlr/dev/ansible/ansible-dev/lib/ansible
  executable location = /home/mikedlr/dev/ansible/ansible-dev/bin/ansible
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
ADDITIONAL INFORMATION

The integration tests on this branch may run for an impractically long time, up to 2hours, especially as various new cases are being added.

DO NOT MERGE THIS TO DEVEL

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 22, 2017

@mikedlr this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 22, 2017

The test ansible-test sanity --test import --python 2.6 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:78:0: ImportError: cannot import name RDSDBInstance
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:90:0: ImportError: cannot import name RDSSnapshot

The test ansible-test sanity --test import --python 2.7 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:78:0: ImportError: cannot import name RDSDBInstance
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:90:0: ImportError: cannot import name RDSSnapshot

The test ansible-test sanity --test import --python 3.5 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:78:0: ImportError: cannot import name 'RDSDBInstance'
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:90:0: ImportError: cannot import name 'RDSSnapshot'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:78:0: ImportError: cannot import name 'RDSDBInstance'
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:90:0: ImportError: cannot import name 'RDSSnapshot'

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:0:0: E307 version_added should be 2.5. Currently 2.4
lib/ansible/modules/cloud/amazon/rds_instance_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/cloud/amazon/rds_snapshot.py:0:0: E307 version_added should be 2.5. Currently 2.4
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:0:0: E307 version_added should be 2.5. Currently 2.4
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 22, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 22, 2017

@mikedlr this PR contains more than one new module.

Please submit only one new module per pullrequest. For further explanation, please read grouped module documentation

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 25, 2017

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance_facts.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/cloud/amazon/rds_snapshot.py:0:0: E307 version_added should be 2.5. Currently 2.4
lib/ansible/modules/cloud/amazon/rds_snapshot_facts.py:0:0: E307 version_added should be 2.5. Currently 2.4

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 27, 2017

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:328:0: ImportError: No module named six

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:328:0: ImportError: No module named six

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:328:0: ImportError: No module named 'six'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:328:0: ModuleNotFoundError: No module named 'six'

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/rds_instance.py:467:28: E127 continuation line over-indented for visual indent
lib/ansible/modules/cloud/amazon/rds_instance.py:469:25: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test use-compat-six [?] failed with the following error:

Command "test/sanity/code-smell/use-compat-six.sh" returned exit status 1.
>>> Standard Output
lib/ansible/modules/cloud/amazon/rds_instance.py:from six import print_

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:354:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 28, 2017

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:338:0: ImportError: No module named botocore

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:338:0: ImportError: No module named botocore

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:338:0: ImportError: No module named 'botocore'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/modules/cloud/amazon/rds_instance.py:338:0: ModuleNotFoundError: No module named 'botocore'

The test ansible-test sanity --test pep8 [?] failed with the following error:

test/units/modules/cloud/amazon/test_rds.py:180:161: E501 line too long (177 > 160 characters)

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 6, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/aws/rds.py:120:24: E225 missing whitespace around operator
lib/ansible/module_utils/aws/rds.py:128:24: E225 missing whitespace around operator
lib/ansible/module_utils/aws/rds.py:132:43: E713 test for membership should be 'not in'

click here for bot help

willthames and others added some commits Oct 19, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 18, 2018

Thanks @mikedlr! This PR was evaluated as a bad PR for the following reasons:

  • More than 50 commits.

Such PR can only be merged by human, contact core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment