New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25725: strip quotes from lsb_release and distribution descript… #31143

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@ioggstream
Contributor

ioggstream commented Oct 1, 2017

SUMMARY

Strip quotes from distribution output retrieved by lsb_release or /etc/xxx-release

Fixes #25725

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

set_fact module

ANSIBLE VERSION
ansible 2.5.0 (25725-fix-set_facts-distro-quotes 19e4047e81) last updated 2017/10/01 06:28:16 (GMT +200)
  config file = /home/rpolli/workspace-ansible/ansible/ansible.cfg
  configured module search path = [u'/home/rpolli/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/rpolli/workspace-ansible/ansible/lib/ansible
  executable location = /home/rpolli/workspace-ansible/ansible/bin/ansible
  python version = 2.7.13 (default, May 10 2017, 20:04:36) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 1, 2017

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/module_utils/facts/system/distribution.py:98:5: E303 too many blank lines (2)

click here for bot help

@ioggstream ioggstream force-pushed the ioggstream:25725-fix-set_facts-distro-quotes branch Oct 1, 2017

@bcoca bcoca removed the needs_triage label Oct 2, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Oct 3, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Oct 3, 2017

The timeout is unrelated. I didn't restart CI since there were also unit test failures.

@mattclay mattclay added the ci_verified label Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment