Fix backwards compatibility of constants.get_config #31200
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_config would use ConfigManager.get_ini_value which does not exist. What we are meant to use is ansible.config.manager.get_ini_config_value and this method does not expect a list, only a dictionary with a section and a key.
|
LGTM |
ansibot
added
affects_2.5
ansibot
added
needs_revision
|
backported for 2.4.1 |
openstack-gerrit
pushed a commit
to ansible-community/ara
that referenced
this pull request
Oct 5, 2017
Due to a misunderstanding of how configuration loading occured in Ansible 2.4, we did not load the configuration file. It turns out we have to do it ourselves now so let's do that. This also requires a fix in the Ansible get_config method which was merged [1] and backported for 2.4.1.0. We're not going to work around the bug in Ansible 2.4.0.0 and as such, blacklist that version and coordinate a new ARA release with Ansible 2.4.1.0. [1]: ansible/ansible#31200 Change-Id: I691ef992c9c6b698f03927e2b69de26f0c1d57d1 (cherry picked from commit 8747ff4)
openstack-gerrit
pushed a commit
to ansible-community/ara
that referenced
this pull request
Oct 5, 2017
Due to a misunderstanding of how configuration loading occured in Ansible 2.4, we did not load the configuration file. It turns out we have to do it ourselves now so let's do that. This also requires a fix in the Ansible get_config method which was merged [1] and backported for 2.4.1.0. We're not going to work around the bug in Ansible 2.4.0.0 and as such, blacklist that version and coordinate a new ARA release with Ansible 2.4.1.0. [1]: ansible/ansible#31200 Change-Id: I691ef992c9c6b698f03927e2b69de26f0c1d57d1
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_config would use ConfigManager.get_ini_value which does not
exist. What we are meant to use is
ansible.config.manager.get_ini_config_value and this method does not
expect a list, only a dictionary with a section and a key.
SUMMARY
get_config used ConfigManager.get_ini_value which does not exist and was silently failing due to the blind exception pass.
This caused configuration parameters to be set to their defaults.
ISSUE TYPE
COMPONENT NAME
ConfigManager
ANSIBLE VERSION
Applicable to Ansible 2.4 and 2.5