Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_nssm AppEnvironmentExtra support #31748

Open
wants to merge 12 commits into
base: devel
from

Conversation

@Geethree
Copy link

commented Oct 15, 2017

SUMMARY

Nssm has the ability to set extra environment variables that extend the service's default environment.

This PR extends the current win_nssm module by adding an optional parameter, environment, that accepts a dictionary that is then properly formatted and set on the service.

ISSUE TYPE
  • Feature Pull Request
EXAMPLE
win_nssm
  name: run_program
  environment:
    FOO: BAR

Adds the variable FOO=BAR to the environment of the run_program service.

ANSIBLE VERSION
ansible 2.4.0.0
  config file = None
  configured module search path = ['/Users/geethree/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.2 (default, Jul 17 2017, 16:44:45) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
ADDITIONAL INFORMATION

Tested against windows 7 and 10

@ansibot

This comment has been minimized.

@jhawkesworth
Copy link
Contributor

left a comment

Thanks for this, that's a nice feature.

I have a couple of thoughts.

Convert-Hash and Convert-array-to-hash appear to be generic so I wonder if there might be similar functions elsewhere, or if not, perhaps they would be better in a Psm1 module so that they can be be re-used. If so perhaps tighten up the names and match the powershell naming convention i.e. Convert-HashToString and Convert-ArrayToHash.

@ansibot ansibot removed the needs_triage label Oct 15, 2017

Geethree added 3 commits Oct 15, 2017
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2017

@ansibot ansibot added the stale_ci label Oct 27, 2017

@ansibot ansibot removed the new_contributor label Nov 4, 2017

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2017

@Geethree

This comment has been minimized.

Copy link
Author

commented Nov 21, 2017

@jborean93 I'll get to these this weekend, life has been busy and this PR was on the back burner.

@ansible ansible deleted a comment from ansibot Dec 3, 2017

@ansible ansible deleted a comment from Geethree Dec 3, 2017

@dagwieers

This comment has been minimized.

Copy link
Member

commented Dec 3, 2017

Beware that the deadline for getting new features/modules accepted in Ansible v2.5 is nearing, it is set to either 2018-01-15 or 2018-01-31. If you are blocked, or you need feedback, please discuss on IRC channel #ansible-windows or add a comment to the Windows Working Group meeting agenda to get it resolved.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2018

@ngile

This comment has been minimized.

Copy link

commented Apr 10, 2018

ping

@ngile

This comment has been minimized.

Copy link

commented May 14, 2018

Any updates on this?

@dagwieers

This comment has been minimized.

Copy link
Member

commented May 14, 2018

Beware that the deadline for getting new features/modules accepted in Ansible v2.6 is nearing, it is set to either 2018-05-17 or 2018-05-25. If you are blocked, or you need feedback, please discuss on IRC channel #ansible-windows or add a comment to the Windows Working Group meeting agenda to get it resolved.

@dagwieers

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

Beware that the deadline for getting new features/modules accepted in Ansible v2.7 is nearing, it is set to either 2018-08-23 or 2018-08-30. If you are blocked, or you need feedback, please discuss on IRC channel #ansible-windows or add a comment to the Windows Working Group meeting agenda to get it resolved.

@ngile

This comment has been minimized.

Copy link

commented Sep 11, 2018

Any updates?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@Geethree win_nssm got a refactor under #45693 so now you have conflicts unfortunately. If you are still interested in adding this feature please can you rebase your PR and address comments above?

@ansibot ansibot added the has_issue label Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.