Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ansible-test sanity command. #31958

Merged
merged 23 commits into from Oct 26, 2017
Merged

Update ansible-test sanity command. #31958

merged 23 commits into from Oct 26, 2017

Conversation

mattclay
Copy link
Member

SUMMARY

Update ansible-test sanity command:

  • Run sanity tests in a docker container.
  • Add git fallback for validate-modules.
  • Use correct pip version in ansible-test.
  • Use correct python version for sanity tests.
  • Pin docker completion images and add default.
  • Split pylint execution into multiple contexts.
  • Only test .py files in use-argspec-type-path test.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-test

ANSIBLE VERSION
ansible 2.5.0 (at-sanity-docker a151a5aac3) last updated 2017/10/19 15:25:15 (GMT -700)
  config file = None
  configured module search path = [u'/Users/mclay/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mclay/code/mattclay/ansible/lib/ansible
  executable location = /Users/mclay/code/mattclay/ansible/bin/ansible
  python version = 2.7.13 (default, Jul 18 2017, 09:17:00) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 19, 2017
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 19, 2017
@gundalow gundalow added the ci_verified Changes made in this PR are causing tests to fail. label Oct 23, 2017
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 23, 2017
@mattclay
Run sanity tests in a docker container.
66ea146
@mattclay
Add git fallback for validate-modules.
b6519d0 
This allows validate-modules to function without git installed,
or when the source does not include the .git directory. This does
not work when specifying --base-branch, as that requires git.
@mattclay
Use correct pip version in ansible-test.
9045167
@mattclay
Use correct python version for sanity tests.
cb37a83
@mattclay
Pin docker completion images and add default.
d052da8
@mattclay
Split pylint execution into multiple contexts.
3ececa5
@mattclay
Only test .py files in use-argspec-type-path test.
6d653cc
@mattclay
Accept identical python interpeter name or binary.
f819195
@mattclay
Switch cloud tests to default container.
151865f
@mattclay
Remove unused extras from pip install.
993d0c2
@mattclay
Filter out empty pip commands.
17b9e67
@mattclay
Don't force running of pip list.
87eaebe
@mattclay
Update default Docker image SHA.
93404cf
@mattclay
Support delegation for windows and network tests.
8faa44c
@mattclay
Fix ansible-test python version usage.
f21a766
@mattclay
Fix ansible-test python version skipping.
d9b7e8c
@mattclay
Update default container hash.
20770d8
@mattclay
Use absolute path for log in ansible-test.
c84558a
@mattclay
Run vyos_command test on python 3.
67f9423
@mattclay
Fix windows/network instance persistence.
575f604
@ansibot
Copy link
Contributor

ansibot commented Oct 24, 2017

cc @Qalthos
click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2017

cc @resmo
click here for bot help

@ansibot ansibot added cloud cloudstack and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 25, 2017
@mattclay
Fix cs_router test.
dad3c4e 
ci_complete
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 26, 2017
@mattclay mattclay merged commit cf1337c into ansible:devel Oct 26, 2017
@mattclay mattclay deleted the at-sanity-docker branch October 26, 2017 07:21
mattclay added a commit to mattclay/ansible that referenced this pull request Oct 26, 2017
@mattclay
Update ansible-test sanity command. (ansible#31958)
05ecfa9 
* Use correct pip version in ansible-test.
* Add git fallback for validate-modules.
* Run sanity tests in a docker container.
* Use correct python version for sanity tests.
* Pin docker completion images and add default.
* Split pylint execution into multiple contexts.
* Only test .py files in use-argspec-type-path test.
* Accept identical python interpeter name or binary.
* Switch cloud tests to default container.
* Remove unused extras from pip install.
* Filter out empty pip commands.
* Don't force running of pip list.
* Support delegation for windows and network tests.
* Fix ansible-test python version usage.
* Fix ansible-test python version skipping.
* Use absolute path for log in ansible-test.
* Run vyos_command test on python 3.
* Fix windows/network instance persistence.
* Add `test/cache` dir to classification.
* Enable more python versions for network tests.
* Fix cs_router test.

(cherry picked from commit cf1337c)
mattclay added a commit that referenced this pull request Oct 26, 2017
@mattclay
Update ansible-test sanity command. (#31958)
8d91a6d 
* Use correct pip version in ansible-test.
* Add git fallback for validate-modules.
* Run sanity tests in a docker container.
* Use correct python version for sanity tests.
* Pin docker completion images and add default.
* Split pylint execution into multiple contexts.
* Only test .py files in use-argspec-type-path test.
* Accept identical python interpeter name or binary.
* Switch cloud tests to default container.
* Remove unused extras from pip install.
* Filter out empty pip commands.
* Don't force running of pip list.
* Support delegation for windows and network tests.
* Fix ansible-test python version usage.
* Fix ansible-test python version skipping.
* Use absolute path for log in ansible-test.
* Run vyos_command test on python 3.
* Fix windows/network instance persistence.
* Add `test/cache` dir to classification.
* Enable more python versions for network tests.
* Fix cs_router test.

(cherry picked from commit cf1337c)
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cloud cloudstack feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattclay @ansibot @gundalow