Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul removed check for service name in parse_service #33310

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@malmon
Copy link

malmon commented Nov 27, 2017

SUMMARY

Removed check in parse_service, as it was causing issues with registering Node level Checks.

Per the module documentation, you can omit service name if you are creating a Node level health check. In parse_service it causes an error if service name is not set, with this check removed the function will return a null which will checked in the add function at 252.

if not service and not check:
        module.fail_json(msg='a name and port are required to register a service')
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

consul

ANSIBLE VERSION
ansible 2.4.1.0
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Nov 27, 2017

@educriado

This comment has been minimized.

Copy link

educriado commented Sep 20, 2018

I have the same issue trying to register a node health check. My version of ansible is 2.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.