Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vim modeline to galaxy-templates #33548

Open
wants to merge 3 commits into
base: devel
from

Conversation

@sperreault
Copy link

commented Dec 4, 2017

SUMMARY

Add vim modeline to ansible-galaxy templates to make vim behave properly with yaml files. This way quick edit of yaml files with vim are easier.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/Users/sperreau/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sperreau/venv/ansible-2.4/lib/python2.7/site-packages/ansible
  executable location = /Users/sperreau/venv/ansible-2.4/bin/ansible
  python version = 2.7.14 (default, Oct 30 2017, 14:56:36) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]
ADDITIONAL INFORMATION

Just added a modeline to the jinja2 tempaltes.

@mattclay

This comment has been minimized.

Copy link
Member

commented Dec 6, 2017

CI failure in unit tests:

>               self.assertEqual(expected_string, f.read().strip())
E               AssertionError: '---\n# tasks file for delete_me' != '# vim: noai:ts=2:sw=2:et:\n---\n# tasks file for delete_me'
E               + # vim: noai:ts=2:sw=2:et:
E                 ---
E                 # tasks file for delete_me

test/units/cli/test_galaxy.py:325: AssertionError

@mattclay mattclay added the ci_verified label Dec 6, 2017

@gundalow gundalow requested a review from chouseknecht Dec 6, 2017

@gundalow gundalow removed the needs_triage label Dec 6, 2017

@gundalow gundalow removed the request for review from chouseknecht Dec 6, 2017

@ansibot ansibot added the stale_ci label Dec 14, 2017

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2018

@sperreault this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@sperreault sperreault force-pushed the sperreault:devel branch to 2f7e7b4 Jan 23, 2018

@ansibot ansibot added the test label Jan 23, 2018

@ansibot ansibot added the stale_ci label Feb 6, 2018

@ansibot ansibot added feature and removed feature_pull_request labels Mar 2, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2018

@sperreault this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed the ci_verified label Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.