Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor sentence accuracy improvement #33588

Closed
wants to merge 1 commit into from
Closed

minor sentence accuracy improvement #33588

wants to merge 1 commit into from

Conversation

TheAtomicOption
Copy link
Contributor

SUMMARY

Discussion of the parameter 12.04 in the explanatory paragraph should not be rounded since the function in the example, version_compare(), does not round.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Docs>Tests

ANSIBLE VERSION

Doesn't apply to a specific version. Sorry if this causes problems, but i'm making the edit directly on github so there's no simple way to include this.

ADDITIONAL INFORMATION

@TheAtomicOption
minor accuracy fix
5cf544e 
Don't round the parameter 12.04 in the explanatory paragraph unless `version()` rounds the parameter
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 docs_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 5, 2017
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Dec 6, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 14, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 23, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 14, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2018

cc @dharmabumstead
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 1, 2018
dharmabumstead
dharmabumstead suggested changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase (we restructured the docs - this should go in the user_guide directory). Also needs signoff from someone on the core engineering team.

@abadger
Copy link
Contributor

abadger commented Apr 5, 2018

+1, this is a good change from a technical standpoint.

@bcoca bcoca mentioned this pull request Apr 20, 2018
Merged
@bcoca
Copy link
Member

bcoca commented Apr 20, 2018

closing as it was rebased and merged in PR linked above

@bcoca bcoca closed this Apr 20, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead requested changes

Assignees

@abadger abadger

@bcoca bcoca

Labels
affects_2.5 This issue/PR affects Ansible v2.5 docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheAtomicOption @ansibot @abadger @bcoca @dharmabumstead @Akasurde