Add os-release file parsing, partially fix #25897

[mscherer]

SUMMARY

Add os-release file parsing, partially fix #25897
/etc/os_release is documented on https://www.freedesktop.org/software/systemd/man/os-release.html

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

setup

ANSIBLE VERSION

$ ansible --version
ansible 2.5.0 (add_fact_os_release 1b2081dfbb) last updated 2017/12/12 15:56:51 (GMT +200)
  config file = /home/misc/.ansible.cfg
  configured module search path = [u'/home/misc/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/misc/checkout/git/ansible/lib/ansible
  executable location = /home/misc/checkout/git/ansible/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

[mscherer]

I didn't took a look at testing that yet, but plan to add it to the unit tests.

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/facts/system/os_release.py:37:19: E231 missing whitespace after ','
lib/ansible/module_utils/facts/system/os_release.py:51:1: W391 blank line at end of file

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/module_utils/facts/system/os_release.py:51:0: trailing-newlines Trailing newlines

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/facts/system/os_release.py:37:19: E231 missing whitespace after ','
lib/ansible/module_utils/facts/system/os_release.py:51:1: W391 blank line at end of file

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/module_utils/facts/system/os_release.py:51:0: trailing-newlines Trailing newlines

click here for bot help

[pilou-]

Although it doesn't count: shipit .

[alikins]

I'd like to see the parse function be pulled out of the class. And for it to take a string for input and tests updated to use it.

[alikins]

@mscherer #25725 and #31143 are the issue/pr related to the quoting in /etc/os-release I mentioned

moved on

[bcoca]

Sorry we kept you hanging this long.

We are going to close this as os-release parsing was included in the vendored/updated distribution detection and for the few extra fields we don't return a simple custom inventory plugin can now be added to the default gather_facts action to get the same result.

However, we're always up for discussion.

Because this project is very active, we're unlikely to see comments made on closed tickets and we lock them after some time.
If you or anyone else has any further questions, please let us know by using any of the communication methods listed on the page below:

• https://docs.ansible.com/ansible/latest/community/communication.html

In the future, sometimes starting a discussion on the Ansible Forum before implementing
a feature can make getting things included a little easier, but it's not always necessary.

Thank you once again for this and your interest in Ansible!

[septatrix]

We are going to close this as os-release parsing was included in the vendored/updated distribution detection and for the few extra fields we don't return a simple custom inventory plugin can now be added to the default gather_facts action to get the same result.

Is there any documentation/guide on writing custom gather_facts modules?

[bcoca]

it is just a facts_module, that you can reference via configuration to have the gather_facts option use automatically.

https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_general.html#creating-an-info-or-a-facts-module

TLDR: retun the info under ansible_facts dictionary.