Hardlink follow

[odra]

SUMMARY

Uses os.readlink to retrieve the link's full path when hard linking a soft link (using follow: true).

Fixes #33911

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

File

ANSIBLE VERSION

ansible 2.5.0
  config file = None
  configured module search path = [u'/home/lrossetti/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/lrossetti/Work/ansible/venv/lib/python2.7/site-packages/ansible-2.5.0-py2.7.egg/ansible
  executable location = /home/lrossetti/Work/ansible/venv/bin/ansible
  python version = 2.7.14 (default, Nov  3 2017, 10:55:25) [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)]

ADDITIONAL INFORMATION

I created an additional task in the module's integration test, sample usage:

-
  hosts: localhost
  tasks:
    - 
      name: Run hard link test
      include_role:
        name: file_test
        tasks_from: hard_link_follow.yml
  vars:
    output_dir: ~/tmp

Note: not sure if this is the best approach to test this, I tried to use the file role test (main.yml) but it failed a couple of times to me + this test felt like it should be an isolated test case on its own.

[caphrim007]

@odra what were the failures you mentioned that prevent it from being in the file target?

[bcoca]

islink and readlink only works with symlinks. Also, this makes no sense for hardlinks, they don't have a canonical source, both entries ARE the file.

[odra]

It is failing to create a hard link when using a symlink path as its src, that's why I used those functions to retrieve the symlink original path.

[odra]

@caphrim007 the first error I get is this one:

fatal: [localhost]: FAILED! => {
    "assertion": "file3_result.mode == '0644'", 
    "changed": false, 
    "evaluated_to": false
}

It creates an empty file with a different permission than the expected one, if I comment that particular check, it fails on this step:

fatal: [localhost]: FAILED! => {
    "assertion": "file4_result.changed == true", 
    "changed": false, 
    "evaluated_to": false
}

[odra]

Hello @bcoca I have removed the hard link so the change is applied for both link types.

[samdoran]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.