New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new module to enable/disable balancer manager for apache 2.2 #34247

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@nikhil-zadoo

nikhil-zadoo commented Dec 26, 2017

SUMMARY

Created a module for apache 2.2 balancer manager. the module makes it possible to enable/disable balancer manager for apache 2.2. there is already a module present for apache 2.4 on the ansible repo, though not for apache 2.2.

COMPONENT NAME

module name - apache22_mod_proxy

ANSIBLE VERSION
ansible --version
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/ansible/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]
ADDITIONAL INFORMATION

NONE

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 26, 2017

The test ansible-test compile --python 3.6 [?] failed with the following error:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:253:18: SyntaxError: self.soup = soup

The test ansible-test compile --python 3.7 [?] failed with the following error:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:253:18: SyntaxError: self.soup = soup

The test ansible-test compile --python 3.5 [?] failed with the following error:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:253:18: SyntaxError: self.soup = soup

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc apache22_mod_proxy" returned exit status 1.
>>> Standard Error
ERROR! module apache22_mod_proxy missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc apache22_mod_proxy" returned exit status 1.
>>> Standard Error
ERROR! module apache22_mod_proxy missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc apache22_mod_proxy" returned exit status 1.
>>> Standard Error
ERROR! module apache22_mod_proxy missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc apache22_mod_proxy" returned exit status 1.
>>> Standard Error
ERROR! module apache22_mod_proxy missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 27, 2017

The test ansible-test sanity --test boilerplate [?] failed with the following error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 27, 2017

@mattclay

This comment has been minimized.

Member

mattclay commented Jan 3, 2018

bot_status

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 3, 2018

The test ansible-test sanity --test import --python 2.6 [?] failed with the following errors:

lib/ansible/module_utils/basic.py:691:0: SystemExit: 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: Output: Import resulted in output to stdout.

The test ansible-test sanity --test import --python 2.7 [?] failed with the following errors:

lib/ansible/module_utils/basic.py:691:0: SystemExit: 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: Output: Import resulted in output to stdout.

The test ansible-test sanity --test import --python 3.5 [?] failed with the following errors:

lib/ansible/module_utils/basic.py:691:0: SystemExit: 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: Output: Import resulted in output to stdout.

The test ansible-test sanity --test import --python 3.6 [?] failed with the following errors:

lib/ansible/module_utils/basic.py:691:0: SystemExit: 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: Output: Import resulted in output to stdout.

The test ansible-test sanity --test import --python 3.7 [?] failed with the following errors:

lib/ansible/module_utils/basic.py:691:0: SystemExit: 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: Output: Import resulted in output to stdout.

The test ansible-test sanity --test no-assert [?] failed with the following error:

Command "test/sanity/code-smell/no-assert.py" returned exit status 1.
>>> Standard Output
Use of assert in production code is not recommended.
Python will remove all assert statements if run with optimizations
Alternatives:
    if not isinstance(value, dict):
        raise AssertionError("Expected a dict for value")
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:268:13:             assert balancer_member_page[1]['status'] == 200
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:327:13:             assert response[1]['status'] == 200
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:355:13:             assert page[1]['status'] == 200
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:375:21:                     assert balancer_member_suffix is not ''

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:203:161: E501 line too long (161 > 160 characters)
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:208:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:208:50: E261 at least two spaces before inline comment
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:256:25: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:292:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:292:1: W191 indentation contains tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:292:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:293:1: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:305:39: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:313:52: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:320:48: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:323:48: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:362:161: E501 line too long (191 > 160 characters)
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:380:104: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:382:84: E231 missing whitespace after ','
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:413:161: E501 line too long (179 > 160 characters)

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:256:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:292:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:305:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:314:0: anomalous-backslash-in-string Anomalous backslash in string: '\='. String constant might be missing an r prefix.
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:314:0: anomalous-backslash-in-string Anomalous backslash in string: '\='. String constant might be missing an r prefix.
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:314:0: anomalous-backslash-in-string Anomalous backslash in string: '\w'. String constant might be missing an r prefix.
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:314:0: anomalous-backslash-in-string Anomalous backslash in string: '\w'. String constant might be missing an r prefix.

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: E307 version_added should be 2.5. Currently 1.0
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:192:7: E313 RETURN is not valid YAML
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:256:24: E402 indentation contains tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:292:0: E402 indentation contains tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:305:38: E402 indentation contains tabs
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:484:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py:485:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 3, 2018

Components

lib/ansible/modules/web_infrastructure/apache22_mod_proxy.py
support: community
maintainers:

Metadata

waiting_on: nikhil-zadoo
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
mergeable_state: unstable
shippable_status: failure
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment