New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds external param for gitlab_user module #34255

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@RafPe

RafPe commented Dec 27, 2017

SUMMARY

Adds support for external parameter for gitlab_user module allowing create/update user with this new property.

ISSUE TYPE
  • Existing Module Pull Request
COMPONENT NAME
  • gitlab_user
ANSIBLE VERSION
ansible 2.4.1.0
  config file = /Users/rafpe/config/ansible.cfg
  configured module search path = [u'/Users/rafpe/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/2.4.1.0/libexec/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Sep 25 2017, 09:53:22) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]

ADDITIONAL INFORMATION

n/a

Modified param for docs for external
Simple add of external attribute for gitlab_user module
@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 27, 2017

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 27, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/source_control/gitlab_user.py:74:24: W291 trailing whitespace
lib/ansible/modules/source_control/gitlab_user.py:75:23: W291 trailing whitespace
lib/ansible/modules/source_control/gitlab_user.py:173:161: E501 line too long (172 > 160 characters)
lib/ansible/modules/source_control/gitlab_user.py:196:46: W291 trailing whitespace
lib/ansible/modules/source_control/gitlab_user.py:371:159: E231 missing whitespace after ','
lib/ansible/modules/source_control/gitlab_user.py:371:161: E501 line too long (168 > 160 characters)

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/source_control/gitlab_user.py:196:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/source_control/gitlab_user.py:0:0: E309 version_added for new option (external) should be 2.5. Currently 0.0

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment