New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for awsvpc on ecs_taskdefinition module and ecs_service #34369

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@jorgegviana

jorgegviana commented Jan 2, 2018

SUMMARY

Add support for awsvpc on ecs_taskdefinition module and network_configuration parameter to ecs_service (required for awsvpc).

Add option 'awsvpc' for network_configuration parameter in ecs_taskdefinition module
Add parameter network_configuration in ecs_service (required to create a service using awsvpn network mode)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_taskdefinition
ecs_service

ANSIBLE VERSION
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/jviana/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.12 (default, Jun 29 2016, 14:05:02) [GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)]
ADDITIONAL INFORMATION
Add support for awsvpc on ecs_taskdefinition module and network_confi…
…guration parameter to ecs_service (required for awsvpc).
@ansibot

This comment has been minimized.

@willthames

This comment has been minimized.

Contributor

willthames commented Jan 3, 2018

I've been working on this too - I've just created a WIP PR at #34831 to compare approaches

The main points of comparison are

  • Updated documentation
  • Updated tests
  • Checks whether botocore can cope with networkConfiguration before passing it through as a parameter
  • network_configuration parameter is in Ansible format, and can cope with named security groups as well as security group IDs

If you can apply a similar approach to ecs_service, then the two PRs combined should get us pretty close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment