New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules #34778

Merged
merged 4 commits into from Jan 15, 2018

Conversation

Projects
None yet
3 participants
@trishnaguha
Member

trishnaguha commented Jan 12, 2018

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY
  • Fix connection getting overridden by network_cli for transport nxapi, eapi for net_* modules. Should be connection local.
  • Define transport based provider functions in individual action plugins.
  • Add missing net_system test for nxos_system module for nxapi
  • Add net_* eos tests for eapi.
  • Fix syntax error net_user playbook nxos_user
  • Add better Debug statement for net_* module in nxos tests to understand what is happening.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/action/net_base.py
plugins/action/eos.py
plugins/action/nxos.py
test/integration/nxos_logging
test/integration/nxos_system
test/integration/nxos_user
test/integration/eos_/tests/eapi/net_

ANSIBLE VERSION
devel

@trishnaguha trishnaguha requested review from privateip, Qalthos and ganeshrn Jan 12, 2018

@trishnaguha trishnaguha added this to the 2.5.0 milestone Jan 12, 2018

@ansibot

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated lib/ansible/plugins/action/net_base.py Outdated
Show outdated Hide outdated lib/ansible/plugins/action/net_base.py Outdated
@ganeshrn

Please also add a basic platform agnostic test case for eos eapi.

trishnaguha added some commits Jan 12, 2018

fix connection gets overridden by network_cli for transport nxapi,eap…
…i net_* modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Define functions in individual action plugins to avoid code duplication
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot

This comment has been minimized.

Show comment
Hide comment
Contributor

ansibot commented Jan 15, 2018

Add net_* eos tests for eapi
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@ansibot ansibot removed the needs_revision label Jan 15, 2018

@trishnaguha trishnaguha merged commit 48ecbb8 into ansible:devel Jan 15, 2018

1 check passed

Shippable Run 50519 status is SUCCESS.
Details

@trishnaguha trishnaguha deleted the trishnaguha:fix_nxapi_eapi_for_net_modules branch Jan 15, 2018

@trishnaguha trishnaguha restored the trishnaguha:fix_nxapi_eapi_for_net_modules branch Feb 2, 2018

@trishnaguha trishnaguha deleted the trishnaguha:fix_nxapi_eapi_for_net_modules branch Feb 2, 2018

@ansibot ansibot added bug and removed bugfix_pull_request labels Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment