New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: jboss_config #35106

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@rpieterick

rpieterick commented Jan 19, 2018

SUMMARY

New module to manage JBoss configuration via the JBoss REST management API.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

jboss_config

ANSIBLE VERSION
ansible 2.3.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]
ADDITIONAL INFORMATION

Below is the output from a playbook with the system properties examples:

PLAY [localhost] ***************************************************************

TASK [Gathering Facts] *********************************************************
ok: [localhost]

TASK [remove system properties] ************************************************
changed: [localhost] => {"changed": true, "reload_required": false, "reloaded": false, "result": {"added": [], "removed": [{"address": ["system-property", "org.apache.coyote.http11.Http11Protocol.MAX_HEADER_SIZE"], "new": null, "old": {"value": "32768"}}, {"address": ["system-property", "org.apache.coyote.ajp.MAX_PACKET_SIZE"], "new": null, "old": {"value": "8190"}}], "updated": []}}

TASK [system properties] *******************************************************
changed: [localhost] => {"changed": true, "reload_required": false, "reloaded": false, "result": {"added": [{"address": ["system-property", "org.apache.coyote.http11.Http11Protocol.MAX_HEADER_SIZE"], "new": {"value": "65535"}}, {"address": ["system-property", "org.apache.coyote.ajp.MAX_PACKET_SIZE"], "new": {"value": "16380"}}], "removed": [], "updated": []}}

TASK [system properties change] ************************************************
changed: [localhost] => {"changed": true, "reload_required": false, "reloaded": false, "result": {"added": [], "removed": [], "updated": [{"address": ["system-property", "org.apache.coyote.http11.Http11Protocol.MAX_HEADER_SIZE"], "new": {"value": "32768"}, "old": {"value": "65535"}}, {"address": ["system-property", "org.apache.coyote.ajp.MAX_PACKET_SIZE"], "new": {"value": "8190"}, "old": {"value": "16380"}}]}}

PLAY RECAP *********************************************************************
localhost                  : ok=4    changed=3    unreachable=0    failed=0
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 19, 2018

The test ansible-test sanity --test no-wildcard-import [?] failed with the following error:

Command "test/sanity/code-smell/no-wildcard-import.sh" returned exit status 3.
>>> Standard Output
== Wildcard imports detected ==
./lib/ansible/modules/web_infrastructure/jboss_config.py:from ansible.module_utils.basic import *
./lib/ansible/modules/web_infrastructure/jboss_config.py:from ansible.module_utils.urls import *

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/jboss_config.py:403:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:407:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:411:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:415:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:421:23: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:422:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:422:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:422:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:423:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:423:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:424:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:424:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:425:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:436:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:439:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:440:39: E231 missing whitespace after ':'
lib/ansible/modules/web_infrastructure/jboss_config.py:441:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:442:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:443:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:449:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:450:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:453:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:455:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:456:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:460:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:462:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:463:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:465:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:482:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:494:16: E225 missing whitespace around operator
lib/ansible/modules/web_infrastructure/jboss_config.py:498:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:511:21: E129 visually indented line with same indent as next logical line
lib/ansible/modules/web_infrastructure/jboss_config.py:524:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:530:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:531:36: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:531:38: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:532:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:532:34: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:534:21: E121 continuation line under-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:538:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:541:19: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:542:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:545:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:547:19: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:548:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:550:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:560:19: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:561:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:563:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:583:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:589:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:590:15: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:591:21: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:596:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:617:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:624:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:625:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:627:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:630:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:631:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:634:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:640:27: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:641:33: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:643:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:652:5: E303 too many blank lines (2)
lib/ansible/modules/web_infrastructure/jboss_config.py:657:23: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:658:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:660:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:662:23: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:663:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:666:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:671:23: E222 multiple spaces after operator
lib/ansible/modules/web_infrastructure/jboss_config.py:672:29: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:676:25: E126 continuation line over-indented for hanging indent
lib/ansible/modules/web_infrastructure/jboss_config.py:726:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:733:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:753:1: W293 blank line contains whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:767:12: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:767:14: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:768:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:768:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:769:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:769:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:770:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:770:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:771:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:771:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:772:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:772:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:773:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:773:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:774:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:774:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:775:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:775:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:776:14: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:776:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:781:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:781:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/jboss_config.py:801:1: W293 blank line contains whitespace

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/jboss_config.py:441:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:442:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:583:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:726:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:733:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:753:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/web_infrastructure/jboss_config.py:801:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E319 RETURN.result.contains: extra keys not allowed @ data['contains']. Got {'added': {'description': 'List of dictionaries for keys and values that were added.', 'returned': 'success', 'type': 'complex', 'contains': {'address': {'description': 'List for the location of the change.', 'returned': 'success', 'type': 'list', 'sample': ['system-property', 'org.apache.coyote.ajp.MAX_PACKET_SIZE']}, 'new': {'description': 'Dictionary of keys and values that were added.', 'returned': 'success', 'type': 'dict', 'sample': {'value': '16380'}}}}, 'removed': {'description': 'Lis...
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "client_cert" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "client_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "force" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "force_basic_auth" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "http_agent" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "thirsty" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "use_proxy" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:384:0: E208 module_utils imports should import specific components, not "*"
lib/ansible/modules/web_infrastructure/jboss_config.py:385:0: E208 module_utils imports should import specific components, not "*"
lib/ansible/modules/web_infrastructure/jboss_config.py:691:0: E403 Type comparison using type() found. Use isinstance() instead
lib/ansible/modules/web_infrastructure/jboss_config.py:808:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 19, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E319 RETURN.result.contains: extra keys not allowed @ data['contains']. Got {'added': {'description': 'List of dictionaries for keys and values that were added.', 'returned': 'success', 'type': 'complex', 'contains': {'address': {'description': 'List for the location of the change.', 'returned': 'success', 'type': 'list', 'sample': ['system-property', 'org.apache.coyote.ajp.MAX_PACKET_SIZE']}, 'new': {'description': 'Dictionary of keys and values that were added.', 'returned': 'success', 'type': 'dict', 'sample': {'value': '16380'}}}}, 'removed': {'description': 'Lis...
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "client_cert" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "client_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "force" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "force_basic_auth" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "http_agent" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "thirsty" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "use_proxy" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added the ci_verified label Jan 19, 2018

@ansibot ansibot removed the ci_verified label Jan 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 19, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E319 RETURN.result.contains: extra keys not allowed @ data['contains']. Got {'added': {'description': 'List of dictionaries for keys and values that were added.', 'returned': 'success', 'type': 'complex', 'contains': {'address': {'description': 'List for the location of the change.', 'returned': 'success', 'type': 'list', 'sample': ['system-property', 'org.apache.coyote.ajp.MAX_PACKET_SIZE']}, 'new': {'description': 'Dictionary of keys and values that were added.', 'returned': 'success', 'type': 'dict', 'sample': {'value': '16380'}}}}, 'removed': {'description': 'Lis...

click here for bot help

@ansibot ansibot added the ci_verified label Jan 19, 2018

@ansibot ansibot removed the ci_verified label Jan 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 21, 2018

@Slezhuk @agmezr @berendt @felixfontein @ghjm @hogarthj @inetfuture @jhoekx @jlaska @jtyr @lekum @matburt @mattupstate @mgruener @n0trax @nerzhul @oboukili @ramondelafuente @robinro @scottanderson42 @sermilrod @tarka @tastychutney @wwitzel3

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@sivel sivel removed the needs_triage label Jan 22, 2018

@ansibot ansibot added the stale_ci label Feb 6, 2018

@ansibot ansibot added the jboss label Aug 18, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 19, 2018

@Wolfant

This comment has been minimized.

Wolfant commented Sep 20, 2018

Hi @rpieterick
Nice work by the way , I'll test you module

@gundalow

This comment has been minimized.

Contributor

gundalow commented Dec 3, 2018

@Wolfant Hi, did you get a chance to test this
@jairojunior @wbrefvem any thoughts?

@ansibot ansibot removed the stale_ci label Dec 3, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 3, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_strategies.rst:23:0: duplicate-label: duplicate label strategy_plugins, other instance in /root/ansible/docs/docsite/rst/plugins/strategy.rst

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E325 argument_spec for "include_defaults" defines type="bool" but documentation does not
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E325 argument_spec for "reload" defines type="bool" but documentation does not
lib/ansible/modules/web_infrastructure/jboss_config.py:0:0: E325 argument_spec for "restart" defines type="bool" but documentation does not

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment