New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add evaluation_delay to datadog #35500

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@oziey88

oziey88 commented Jan 30, 2018

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 30, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/monitoring/datadog_monitor.py:0:0: E322 "evaluation_delay" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot removed the ci_verified label Jan 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jan 30, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/monitoring/datadog_monitor.py:0:0: E309 version_added for new option (evaluation_delay) should be 2.5. Currently 2.4

click here for bot help

@ansibot ansibot added the ci_verified label Jan 30, 2018

@@ -296,6 +302,7 @@ def install_monitor(module):
"escalation_message": module.params['escalation_message'],
"notify_audit": module.boolean(module.params['notify_audit']),
"locked": module.boolean(module.params['locked']),
"evaluation_delay": module.params['evaluation_delay'],

This comment has been minimized.

@gundalow

gundalow Jan 31, 2018

Contributor

If null (the default) is passed it does this mean no delay, or does this need to be zero?

This comment has been minimized.

@oziey88

oziey88 Jan 31, 2018

Ya, if you want "no delay", you don't need to define evaluation_delay into .yml

@gundalow gundalow removed the needs_triage label Jan 31, 2018

@ansibot ansibot added the stale_ci label Feb 8, 2018

@ansibot ansibot added feature and removed feature_pull_request labels Mar 2, 2018

@ansibot ansibot added the affects_2.6 label May 21, 2018

description: ["The number of second to delay data evaluation."]
required: false
default: null
version_added: "2.5"

This comment has been minimized.

@maxamillion

maxamillion May 24, 2018

Contributor

This would need to be bumped to 2.6 and get the change in soon, dev freeze is tomorrow.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 19, 2018

@oziey88 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit and removed stale_ci labels Oct 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 19, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/monitoring/datadog_monitor.py:280:14: duplicate-key Duplicate key 'evaluation_delay' in dictionary

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/datadog_monitor.py:105:5: key-duplicates DOCUMENTATION: duplication of key "evaluation_delay" in mapping

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment