New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: iptables_raw #36454

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@tgates81
Contributor

tgates81 commented Feb 20, 2018

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Contributor

ansibot commented Feb 20, 2018

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc iptables_raw" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/ansible/lib/ansible/modules/system/iptables_raw.py, line 21, column 3,
found a duplicate dict key (chains_present). Using last defined value only.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc iptables_raw" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/ansible/lib/ansible/modules/system/iptables_raw.py, line 21, column 3,
found a duplicate dict key (chains_present). Using last defined value only.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc iptables_raw" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/ansible/lib/ansible/modules/system/iptables_raw.py, line 21, column 3,
found a duplicate dict key (chains_present). Using last defined value only.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc iptables_raw" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/ansible/lib/ansible/modules/system/iptables_raw.py, line 21, column 3,
found a duplicate dict key (chains_present). Using last defined value only.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc iptables_raw" returned exit status 0.
>>> Standard Error
[WARNING]: While constructing a mapping from
/root/ansible/lib/ansible/modules/system/iptables_raw.py, line 21, column 3,
found a duplicate dict key (chains_present). Using last defined value only.

The test ansible-test sanity --test boilerplate [explain] failed with the error:

Command "test/sanity/code-smell/boilerplate.sh" returned exit status 2.
>>> Standard Output
== Missing __metaclass__ = type ==
./lib/ansible/modules/system/iptables_raw.py

== Missing from __future__ import (absolute_import, division, print_function) ==
./lib/ansible/modules/system/iptables_raw.py

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: E326 Value for "choices" from the argument_spec (['filter', 'nat', 'mangle', 'raw', 'security']) for "table" does not match the documentation ([])

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:62:3: key-duplicates DOCUMENTATION: duplication of key "chains_present" in mapping

click here for bot help

@tgates81

This comment has been minimized.

Contributor

tgates81 commented May 25, 2018

Any interest in this module? No human activity for a long time.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 27, 2018

@tgates81 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@tgates81 tgates81 force-pushed the tgates81:iptables_raw branch Aug 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 27, 2018

@tgates81 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: module should not be executable

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@tgates81 tgates81 force-pushed the tgates81:iptables_raw branch to 822d116 Aug 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: module should not be executable

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@ansibot ansibot removed the ci_verified label Aug 27, 2018

@ansibot ansibot added the stale_ci label Sep 4, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 14, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/iptables_raw.py:0:0: E307 version_added should be 2.8. Currently 2.7

click here for bot help

@ansibot ansibot added ci_verified and removed stale_ci labels Sep 14, 2018

@ansibot ansibot added the stale_ci label Sep 22, 2018

@bcoca bcoca referenced this pull request Oct 2, 2018

Open

Adds iptables_raw module #21054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment