Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template action respect local_tmp. Fixes #34941 (#35005) #36572

Closed
wants to merge 1 commit into from

Conversation

TristanCacqueray
Copy link
Contributor

SUMMARY

Backport devel fix

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

templates

ANSIBLE VERSION

ansible 2.4.3.0

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 22, 2018
@mkrizek
Copy link
Contributor

mkrizek commented Feb 23, 2018

cc @abadger

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2018
@abadger
Copy link
Contributor

abadger commented Feb 23, 2018 via email

@TristanCacqueray
Copy link
Contributor Author

It can also be considered a bug/regression fix because the 2.3 version of the template module wasn't using a temporary file.

@abadger
Copy link
Contributor

abadger commented Feb 24, 2018

2.3 had similar behaviour. The only difference is that 2.3 created a temporary file and 2.3 (EDIT: 2.4) creates a temporary directory into which it places the temporary file. This is not a regression. I'm not sure whether it is a bugfix; we didn't have any overarching policy to put local temporary files into local_tmp until 2.5.

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 10, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2018
@mattclay
Copy link
Member

Ansible 2.4 is end-of-life and is no longer supported.

Backports or other changes to EOL branches are not accepted.

@mattclay mattclay closed this Oct 16, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants