-
Notifications
You must be signed in to change notification settings - Fork 24k
[WIP] Start of flexible duration specification #36878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sivel
wants to merge
8
commits into
ansible:devel
Choose a base branch
from
sivel:duration
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+226
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test
|
looks legit to me but I'm pretty sure my +1 doesnt do anything in the system 😁 |
@rackergs thanks! and sorry for the ping. Meant to have the bot skip this for the time being. |
bot_skip |
Closed
Any news about this ? |
/azp run |
Pull request contains merge conflicts. |
/azp run |
Pull request contains merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci_verified
Changes made in this PR are causing tests to fail.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
unimportant_ci
This PR does not need to have healthy CI status and should be ignored by the CI infra maintainers.
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR aims to provide a more flexible duration spec for use in user input, instead of relying on the user providing an integer defining seconds, or in cases where a module accepts
seconds
andminutes
as exclusive parameters.Using this, a module could define:
The user would provide something like the following:
The
duration
type function, returns adatetime.timedelta
object, and if the module needs seconds it can rely onparams['duration'].total_seconds()
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/parsing/duration.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
The
human_time_delta
andtimedelta_to_dict
functions probably don't belong inparsing
, eventually they should move totext.format