New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP ec2_vpc_endpoint: allow endpoints to be modified #37036

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@s-hertel
Contributor

s-hertel commented Mar 5, 2018

SUMMARY

Adding integration tests.

Allows endpoints to be modified if the vpc_endpoint_id option is provided when state == present. Allows policies and routes to be updated while maintaining backwards compatibility.

Backwards compat:

  • Add integration tests for Ansible <= 2.5 behavior

New feature:

  • Add a purge_route_tables option
  • Allow route_table_ids and policy to be updated after VPC endpoint creation by specifying vpc_endpoint_id with state=present (previously only allowed for state=absent)
  • add an example for updating endpoints
  • Add integration tests for modifying endpoints

Exception handling:

  • Remove exception handling around the boto3 connection
  • Handle BotoCoreErrors instead of ‘Exception’
  • Use AnsibleAWSModule for simple exception handling

Fixes:

  • Fix wait: yes for state=absent and update the documentation
  • Fix idempotence for deleting an endpoint
  • Report changed=true when successfully deleting an endpoint
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2_vpc_endpoint.py

ANSIBLE VERSION
2.6.0
@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 5, 2018

@s-hertel s-hertel removed the needs_triage label Mar 5, 2018

@s-hertel s-hertel force-pushed the s-hertel:vpc_endpoint_feature branch 4 times, most recently Mar 5, 2018

@ansible ansible deleted a comment from ansibot Mar 5, 2018

@ansible ansible deleted a comment from ansibot Mar 5, 2018

@s-hertel s-hertel force-pushed the s-hertel:vpc_endpoint_feature branch 2 times, most recently Mar 5, 2018

@ansibot ansibot added needs_ci and removed needs_ci labels Mar 5, 2018

@s-hertel s-hertel force-pushed the s-hertel:vpc_endpoint_feature branch Mar 5, 2018

@ansible ansible deleted a comment from ansibot Mar 5, 2018

@s-hertel s-hertel force-pushed the s-hertel:vpc_endpoint_feature branch Mar 6, 2018

@s-hertel s-hertel changed the title from [WIP] ec2_vpc_endpoint: allow endpoints to be modified to ec2_vpc_endpoint: allow endpoints to be modified Mar 6, 2018

@ryansb ryansb self-requested a review Mar 12, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 13, 2018

s-hertel and others added some commits Mar 5, 2018

Add ability to modify VPC endpoints
Move to AnsibleAWSModule

Add BotoCoreError exception handling and remove 'except Exception' from boto calls

Remove e.message from exception handling since it doesn't exist on Python 3

Simplify check mode logic

Fix idempotence with endpoint deletion

Fix waiting for endpoint deletion

@ryansb ryansb force-pushed the s-hertel:vpc_endpoint_feature branch to 58f4bd3 Mar 22, 2018

@ansibot ansibot added needs_revision and removed core_review labels Mar 22, 2018

@s-hertel s-hertel changed the title from ec2_vpc_endpoint: allow endpoints to be modified to WIP ec2_vpc_endpoint: allow endpoints to be modified Mar 22, 2018

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Mar 22, 2018

Since these tests create route tables, do not merge until #36066 has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment