New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud] add custom waiter for target groups when created - fixes #36628 #37079

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@s-hertel
Contributor

s-hertel commented Mar 6, 2018

SUMMARY

Fixes #36628. Wait for a target group to be accessible after creation before subsequent operations.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/elb_target_group.py
lib/ansible/module_utils/aws/waiters.py

ANSIBLE VERSION
2.6.0
@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 6, 2018

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Mar 19, 2018

bot_status

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 19, 2018

Components

lib/ansible/module_utils/aws/waiters.py
support: core
maintainers:

lib/ansible/modules/cloud/amazon/elb_target_group.py
support: community
maintainers: wimnat

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): s-hertel
shipit_actors_other: []

click here for bot help

@ansibot ansibot added core_review and removed needs_info labels Mar 19, 2018

@willthames

This comment has been minimized.

Contributor

willthames commented Mar 21, 2018

This module could really use some tests!

The code looks great to me though. I'll run it in on one of our test environments.

@ansibot ansibot added the stale_ci label Mar 29, 2018

@ryansb ryansb changed the title from [cloud] add customer waiter for target groups when created - fixes #36628 to [cloud] add custom waiter for target groups when created - fixes #36628 Apr 3, 2018

@ryansb

ryansb approved these changes Apr 3, 2018

@ryansb

This comment has been minimized.

Contributor

ryansb commented Apr 3, 2018

@willthames let us know if you're able to validate this. LGTM.

@ansibot ansibot added the stale_ci label May 10, 2018

@ansibot ansibot added the affects_2.6 label May 18, 2018

@s-hertel s-hertel force-pushed the s-hertel:elb_target_group_waiter branch May 30, 2018

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented May 30, 2018

Rebased, added two commits to provide a specific error message for a Waiter exception and remove ec2_argument_spec.

@s-hertel s-hertel force-pushed the s-hertel:elb_target_group_waiter branch Sep 12, 2018

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Sep 12, 2018

Rebased because RDS and EKS waiters were added.

@s-hertel s-hertel force-pushed the s-hertel:elb_target_group_waiter branch to 640212c Sep 12, 2018

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Sep 12, 2018

Also adding a note that the tests I added for elb_target which use elb_target_group do verify this waiter works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment