New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment file feature #37080

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@yrobla

yrobla commented Mar 6, 2018

SUMMARY

Adds a new keyword for the playbooks, named environment_file. It allows to specify a path to a local file, and sources the vars, propagating into the environment dictionary.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible core

ANSIBLE VERSION

2.6

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 6, 2018

@yrobla this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 6, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 6, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/utils/test_vars.py:135:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/utils/vars.py:195:1: E302 expected 2 blank lines, found 1
lib/ansible/utils/vars.py:206:17: E125 continuation line with same indent as next logical line
lib/ansible/utils/vars.py:216:28: E111 indentation is not a multiple of four
lib/ansible/vars/manager.py:423:9: E303 too many blank lines (2)
test/units/utils/test_vars.py:135:1: W391 blank line at end of file

click here for bot help

@ryansb ryansb removed the needs_triage label Mar 6, 2018

@yrobla yrobla force-pushed the yrobla:environment_file branch Mar 6, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Mar 7, 2018

CI failure due to traceback in the integration tests:

2018-03-06 18:54:37 Traceback (most recent call last):
2018-03-06 18:54:37   File "/root/ansible/bin/ansible-playbook", line 118, in <module>
2018-03-06 18:54:37     exit_code = cli.run()
2018-03-06 18:54:37   File "/root/ansible/lib/ansible/cli/playbook.py", line 122, in run
2018-03-06 18:54:37     results = pbex.run()
2018-03-06 18:54:37   File "/root/ansible/lib/ansible/executor/playbook_executor.py", line 159, in run
2018-03-06 18:54:37     result = self._tqm.run(play=play)
2018-03-06 18:54:37   File "/root/ansible/lib/ansible/executor/task_queue_manager.py", line 290, in run
2018-03-06 18:54:37     play_return = strategy.run(iterator, play_context)
2018-03-06 18:54:37   File "/root/ansible/lib/ansible/plugins/strategy/linear.py", line 248, in run
2018-03-06 18:54:37     task_vars = self._variable_manager.get_vars(play=iterator._play, host=host, task=task)
2018-03-06 18:54:37   File "/root/ansible/lib/ansible/vars/manager.py", line 420, in get_vars
2018-03-06 18:54:37     all_vars['environment'][idx].update(environment_file_vars)
2018-03-06 18:54:37 AttributeError: 'AnsibleUnicode' object has no attribute 'update'

@mattclay mattclay added the ci_verified label Mar 7, 2018

@yrobla yrobla force-pushed the yrobla:environment_file branch 2 times, most recently Mar 7, 2018

@ansibot ansibot removed the ci_verified label Mar 7, 2018

@yrobla yrobla changed the title from Environment file to Environment file feature Mar 7, 2018

@yrobla yrobla force-pushed the yrobla:environment_file branch to 4f91d3c Mar 7, 2018

@ansibot ansibot removed the needs_revision label Mar 7, 2018

@ansibot ansibot added the stale_ci label Mar 15, 2018

@ansibot ansibot added the affects_2.6 label May 18, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 6, 2018

@acozine

This comment has been minimized.

Contributor

acozine commented Nov 28, 2018

@yrobla if you'd like some reviews on this PR, join the monthly big PR review on freenode IRC tomorrow.

@ansibot ansibot added the docsite label Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment