New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asa_facts module #37298

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@npokasub

npokasub commented Mar 12, 2018

SUMMARY

Get ASA devices facts

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

asa_facts

ANSIBLE VERSION
ansible 2.4.3.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 12, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 12, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/asa/asa_facts.py:210:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/asa/asa_facts.py:303:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/network/asa/asa_facts.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/network/asa/asa_facts.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/network/asa/asa_facts.py:107:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/asa/asa_facts.py:122:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/asa/asa_facts.py:171:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/asa/asa_facts.py:186:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/asa/asa_facts.py:196:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/asa/asa_facts.py:210:1: W293 blank line contains whitespace
lib/ansible/modules/network/asa/asa_facts.py:303:56: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/asa/asa_facts.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/network/asa/asa_facts.py:0:0: E307 version_added should be 2.6. Currently 2.4
lib/ansible/modules/network/asa/asa_facts.py:0:0: E324 Value for "default" from the argument_spec (['!config']) for "gather_subset" does not match the documentation ('!config')

click here for bot help

DOCUMENTATION = """
---
module: asa_facts
version_added: "2.4.0"

This comment has been minimized.

@gundalow

gundalow Mar 12, 2018

Contributor

version_added: "2.6"

"""
EXAMPLES = """
# Collect all facts from the device

This comment has been minimized.

@gundalow

gundalow Mar 12, 2018

Contributor

Please use - name: Collect all facts from the device rather than a comment.

Same on the rest of the examples

@ansibot ansibot removed the needs_triage label Mar 12, 2018

@@ -0,0 +1,361 @@
#!/usr/bin/python

This comment has been minimized.

@gundalow

gundalow Mar 12, 2018

Contributor

Please change to

#!/usr/bin/python

# Copyright: (c) 2018, Terry Jones <terry.jones@example.org>
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

from __future__ import (absolute_import, division, print_function)
__metaclass__ = type

replacing Terry Jones <terry.jones@example.org> with your details

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 12, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/asa/asa_facts.py:0:0: E324 Value for "default" from the argument_spec (['!config']) for "gather_subset" does not match the documentation ('!config')

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 15, 2018

@npokasub this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@sts

This comment has been minimized.

sts commented Jul 17, 2018

Ansible play gets stuck after loading the facts. The next task won't load. I was able to work around this issue by remving facts['config'] from the module.

https://github.com/ansible/ansible/pull/37298/files#diff-44ad9cd9d84885ed442f061abb7d58faR204

I thought this might be related to pagination, but also when disabling pagination it doesn't work. So this might be a issue with the stored content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment