Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add a __eq__ to TaskInclude #37304

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Mar 12, 2018

SUMMARY

add a eq to TaskInclude

Otherwise a TaskInclude and a TaskInclude.copy() compare
as unequal even when their uuid matches.

[WIP] because I don't remember creating the change or why nor what state it is in.

Somewhat similar to #37083

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/playbook/task_include.py

ANSIBLE VERSION
ansible 2.6.0 (task_include_eq 48e74cd647) last updated 2018/03/12 10:45:02 (GMT -400)
  config file = None
  configured module search path = [u'/home/adrian/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/adrian/src/ansible/lib/ansible
  executable location = /home/adrian/src/ansible/bin/ansible
  python version = 2.7.14 (default, Feb 27 2018, 20:43:24) [GCC 7.3.1 20180130 (Red Hat 7.3.1-2)]


ADDITIONAL INFORMATION

alikins added 7 commits Mar 12, 2018
assertEquals() still fails though
Otherwise a TaskInclude and a TaskInclude.copy() compare
as unequal even when their uuid matches.
@alikins alikins requested review from jimi-c and sivel Mar 12, 2018
@ansibot ansibot added WIP bug needs_triage support:core test labels Mar 12, 2018
@bcoca bcoca removed the needs_triage label Mar 13, 2018
@ansibot ansibot added the stale_ci label Mar 21, 2018
@sivel
Copy link
Member

sivel commented Mar 22, 2018

LGTM

@ansibot ansibot added the affects_2.6 label May 25, 2018
@ansibot ansibot added pre_azp and removed stale_ci labels Dec 6, 2020
@mattclay
Copy link
Member

mattclay commented Jun 22, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the pre_azp label Jun 22, 2022
@mattclay mattclay added the ci_verified label Jun 22, 2022
@ansibot ansibot added the stale_ci label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.6 bug ci_verified small_patch stale_ci support:core test WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants