New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Inspector Run Module #37475

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@dennisconrad
Contributor

dennisconrad commented Mar 15, 2018

SUMMARY

Adds AWS Inspector Run Module

ISSUE TYPE
  • New Module Pull Request
ANSIBLE VERSION
ansible 2.4.3.0
ADDITIONAL INFORMATION

Role for installing AWS Inspector Agents, if required:
https://galaxy.ansible.com/sansible/amazon_inspector_agent/

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 15, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 15, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:156:0: ImportError: No module named botocore.exceptions

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:156:0: ImportError: No module named botocore.exceptions

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:156:0: ImportError: No module named 'botocore'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:156:0: ModuleNotFoundError: No module named 'botocore'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:156:0: ModuleNotFoundError: No module named 'botocore'

The test ansible-test sanity --test validate-modules [explain] failed with 16 errors:

lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (None)
lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot removed the ci_verified label Mar 15, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 15, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @defunctio @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

state: stopped
- name: Query Assessment Run
inspector_run:

This comment has been minimized.

@ryansb

ryansb Apr 30, 2018

Contributor

I think this query function should be separated out into a _facts module.

description:
- The state of the assessment run.
choices:
- started

This comment has been minimized.

@ryansb

ryansb Apr 30, 2018

Contributor

As part of convention for Ansible module UX, we like to have a present option that's the default. For example, on the AWS EC2 modules present is equivalent to ensure the instance exists, and if you must create it then do so. If it exists and is stopped, leave it stopped. For Inspector I'd expect a present to start a job from the specified template, unless one exists already and is stopped or running.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 17, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/inspector_run.py:0:0: E307 version_added should be 2.8. Currently 2.6

click here for bot help

@ansibot ansibot removed the stale_ci label Oct 17, 2018

@ansibot ansibot added the ci_verified label Oct 17, 2018

@ansibot ansibot added the stale_ci label Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment