Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Fixing domain to authorization matching for ACME v2. (#37558) #37572

Merged
merged 1 commit into from
Mar 29, 2018
Merged

[2.5] Fixing domain to authorization matching for ACME v2. (#37558) #37572

merged 1 commit into from
Mar 29, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Mar 18, 2018

(cherry picked from commit 190755f)

SUMMARY

backport of the bug fix #37558

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

letsencrypt

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@felixfontein @resmo
Fixing domain to authorization matching for ACME v2. (#37558)
a429003 
(cherry picked from commit 190755f)
Signed-off-by: Rene Moser <mail@renemoser.net>
@resmo resmo mentioned this pull request Mar 18, 2018
Merged
@resmo resmo changed the title Fixing domain to authorization matching for ACME v2. (#37558) [2.5] Fixing domain to authorization matching for ACME v2. (#37558) Mar 18, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2018

cc @felixfontein @mgruener
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 18, 2018
@felixfontein
Copy link
Contributor

It would be really good if this one could make it into 2.5, since it fixes a serious and embarrassing bug which will cause many problems with ACME v2 certificate issuing (when mixing wildcard with non-wildcard domains).

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 18, 2018
@resmo
Copy link
Contributor Author

resmo commented Mar 18, 2018

@felixfontein yes, I agree, I made the awareness of this patch on the ML. Thanks again for your hard work!

@felixfontein
Copy link
Contributor

@resmo Thanks a lot! I just wish I hadn't introduced that problem in the first place ;)

@felixfontein
Copy link
Contributor

Looks like it didn't make it into 2.5.0 (2c2dd1a) :(

@felixfontein felixfontein mentioned this pull request Mar 23, 2018
Merged
@nitzmahone nitzmahone merged commit 27382f3 into ansible:stable-2.5 Mar 29, 2018
@nitzmahone
Copy link
Member

will be included in 2.5.1

@felixfontein
Copy link
Contributor

@nitzmahone Thanks! Is there any information on when 2.5.1 is planned to be released?

@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@resmo @ansibot @felixfontein @nitzmahone @dagwieers