New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Fixing domain to authorization matching for ACME v2. (#37558) #37572

Merged
merged 1 commit into from Mar 29, 2018

Conversation

4 participants
@resmo
Member

resmo commented Mar 18, 2018

(cherry picked from commit 190755f)

SUMMARY

backport of the bug fix #37558

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

letsencrypt

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

Fixing domain to authorization matching for ACME v2. (#37558)
(cherry picked from commit 190755f)
Signed-off-by: Rene Moser <mail@renemoser.net>

@resmo resmo changed the title from Fixing domain to authorization matching for ACME v2. (#37558) to [2.5] Fixing domain to authorization matching for ACME v2. (#37558) Mar 18, 2018

@ansibot

This comment has been minimized.

Show comment
Hide comment
@ansibot
Contributor

ansibot commented Mar 18, 2018

@felixfontein

This comment has been minimized.

Show comment
Hide comment
@felixfontein

felixfontein Mar 18, 2018

Contributor

It would be really good if this one could make it into 2.5, since it fixes a serious and embarrassing bug which will cause many problems with ACME v2 certificate issuing (when mixing wildcard with non-wildcard domains).

Contributor

felixfontein commented Mar 18, 2018

It would be really good if this one could make it into 2.5, since it fixes a serious and embarrassing bug which will cause many problems with ACME v2 certificate issuing (when mixing wildcard with non-wildcard domains).

@ansibot ansibot removed the needs_triage label Mar 18, 2018

@resmo

This comment has been minimized.

Show comment
Hide comment
@resmo

resmo Mar 18, 2018

Member

@felixfontein yes, I agree, I made the awareness of this patch on the ML. Thanks again for your hard work!

Member

resmo commented Mar 18, 2018

@felixfontein yes, I agree, I made the awareness of this patch on the ML. Thanks again for your hard work!

@felixfontein

This comment has been minimized.

Show comment
Hide comment
@felixfontein

felixfontein Mar 18, 2018

Contributor

@resmo Thanks a lot! I just wish I hadn't introduced that problem in the first place ;)

Contributor

felixfontein commented Mar 18, 2018

@resmo Thanks a lot! I just wish I hadn't introduced that problem in the first place ;)

@resmo resmo added this to To Do in 2.5.x blocker list via automation Mar 20, 2018

@felixfontein

This comment has been minimized.

Show comment
Hide comment
@felixfontein

felixfontein Mar 23, 2018

Contributor

Looks like it didn't make it into 2.5.0 (2c2dd1a) :(

Contributor

felixfontein commented Mar 23, 2018

Looks like it didn't make it into 2.5.0 (2c2dd1a) :(

@nitzmahone nitzmahone merged commit 27382f3 into ansible:stable-2.5 Mar 29, 2018

1 check passed

Shippable Run 58209 status is SUCCESS.
Details
@nitzmahone

This comment has been minimized.

Show comment
Hide comment
@nitzmahone

nitzmahone Mar 29, 2018

Member

will be included in 2.5.1

Member

nitzmahone commented Mar 29, 2018

will be included in 2.5.1

@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Mar 29, 2018

@felixfontein

This comment has been minimized.

Show comment
Hide comment
@felixfontein

felixfontein Mar 30, 2018

Contributor

@nitzmahone Thanks! Is there any information on when 2.5.1 is planned to be released?

Contributor

felixfontein commented Mar 30, 2018

@nitzmahone Thanks! Is there any information on when 2.5.1 is planned to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment