Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Fixing domain to authorization matching for ACME v2. (#37558) #37572

Merged
merged 1 commit into from Mar 29, 2018

Conversation

@resmo
Copy link
Member

@resmo resmo commented Mar 18, 2018

(cherry picked from commit 190755f)

SUMMARY

backport of the bug fix #37558

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

letsencrypt

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

(cherry picked from commit 190755f)
Signed-off-by: Rene Moser <mail@renemoser.net>
@resmo resmo changed the title Fixing domain to authorization matching for ACME v2. (#37558) [2.5] Fixing domain to authorization matching for ACME v2. (#37558) Mar 18, 2018
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 18, 2018

It would be really good if this one could make it into 2.5, since it fixes a serious and embarrassing bug which will cause many problems with ACME v2 certificate issuing (when mixing wildcard with non-wildcard domains).

@ansibot ansibot removed the needs_triage label Mar 18, 2018
@resmo
Copy link
Member Author

@resmo resmo commented Mar 18, 2018

@felixfontein yes, I agree, I made the awareness of this patch on the ML. Thanks again for your hard work!

@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 18, 2018

@resmo Thanks a lot! I just wish I hadn't introduced that problem in the first place ;)

@resmo resmo added this to To Do in 2.5.x blocker list via automation Mar 20, 2018
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 23, 2018

Looks like it didn't make it into 2.5.0 (2c2dd1a) :(

@nitzmahone nitzmahone merged commit 27382f3 into ansible:stable-2.5 Mar 29, 2018
1 check passed
1 check passed
Shippable Run 58209 status is SUCCESS.
Details
@nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented Mar 29, 2018

will be included in 2.5.1

@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Mar 29, 2018
@felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 30, 2018

@nitzmahone Thanks! Is there any information on when 2.5.1 is planned to be released?

@dagwieers dagwieers added the crypto label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.