New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_cert module: add 'trustcacerts' option for certificate import #37707 #37708

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@florianpaulhoberg
Copy link

florianpaulhoberg commented Mar 21, 2018

#37707  added option to add trusted cert to keystore
SUMMARY

This is an implementation of feature request #37707 to add certificates as trusted cacert.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

java_cert module

ANSIBLE VERSION
ansible 2.4.2.0
added option to add trusted cert to keystore
 added option to add trusted cert to keystore
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 21, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/java_cert.py:38:19: W291 trailing whitespace

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Mar 21, 2018

fixed trailing whitespace
 fixed trailing whitespace
@haad

This comment has been minimized.

Copy link
Contributor

haad commented Mar 22, 2018

shipit

@haad

This comment has been minimized.

Copy link
Contributor

haad commented Mar 22, 2018

thanks for your patch!

@ansibot ansibot removed the needs_triage label Mar 22, 2018

@ghost

This comment has been minimized.

Copy link

ghost commented Mar 28, 2018

It looks good and seems like a basic feature, what is holding up this PR?

@haad

This comment has been minimized.

Copy link
Contributor

haad commented Mar 31, 2018

@ansibot ansibot added the stale_ci label Mar 31, 2018

@kaplun

This comment has been minimized.

Copy link

kaplun commented Apr 23, 2018

This feature is badly needed. E.g. in my case it's a blocker for using keytool in ansible to setup certificates for Kafka.

@haad

This comment has been minimized.

Copy link
Contributor

haad commented Apr 23, 2018

shipit

@anaeh

This comment has been minimized.

Copy link
Contributor

anaeh commented May 15, 2018

Please merge the feature.

@florianpaulhoberg

This comment has been minimized.

Copy link

florianpaulhoberg commented May 22, 2018

Any updates?

@ansibot ansibot added the affects_2.6 label May 22, 2018

@florianpaulhoberg

This comment has been minimized.

Copy link

florianpaulhoberg commented Jun 29, 2018

@haad ping

@haad

This comment has been minimized.

Copy link
Contributor

haad commented Jun 29, 2018

We need some other maintainer to mark it as mergable. Right now only me marked it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment