New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql_db: add support for tablespaces #37953

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@m4ci3k2

m4ci3k2 commented Mar 26, 2018

SUMMARY

Add support for specifying tablespace in postgresql_db module, both for creation and moving of existing databases.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_db

ANSIBLE VERSION
devel

@m4ci3k2 m4ci3k2 force-pushed the m4ci3k2:postgres_db_tablespace branch Mar 26, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 26, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 26, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E309 version_added for new option (tablespace) should be 2.6. Currently 2.5
lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E324 Value for "default" from the argument_spec (None) for "tablespace" does not match the documentation ('postgres')

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/setup_postgresql_db/tasks/main.yml:149:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Mar 26, 2018

@ryansb ryansb removed the needs_triage label Mar 27, 2018

@m4ci3k2 m4ci3k2 force-pushed the m4ci3k2:postgres_db_tablespace branch Mar 28, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E309 version_added for new option (tablespace) should be 2.6. Currently 2.5
lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E324 Value for "default" from the argument_spec (None) for "tablespace" does not match the documentation ('postgres')

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/setup_postgresql_db/tasks/main.yml:149:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@m4ci3k2 m4ci3k2 force-pushed the m4ci3k2:postgres_db_tablespace branch to 80f1b1d Mar 28, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E309 version_added for new option (tablespace) should be 2.6. Currently 2.5
lib/ansible/modules/database/postgresql/postgresql_db.py:0:0: E324 Value for "default" from the argument_spec (None) for "tablespace" does not match the documentation ('postgres')

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/setup_postgresql_db/tasks/main.yml:149:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@m4ci3k2 m4ci3k2 force-pushed the m4ci3k2:postgres_db_tablespace branch from 80f1b1d to 1ba6a1c Mar 30, 2018

@m4ci3k2 m4ci3k2 closed this Mar 30, 2018

@m4ci3k2 m4ci3k2 reopened this Mar 30, 2018

@ansibot ansibot added the needs_rebase label Apr 3, 2018

@ansibot ansibot removed the needs_rebase label Apr 11, 2018

@ansibot ansibot added the stale_ci label Apr 11, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Apr 13, 2018

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/59763/25/tests

test/integration/targets/postgresql/tasks/main.yml:111 / [testhost] testhost: postgresql : assert that=[u"result.stdout_lines[-1] == 'CREATE TABLESPACE'"]

failure: The conditional check 'result.stdout_lines[-1] == 'CREATE TABLESPACE'' failed. The error was: error while evaluating conditional (result.stdout_lines[-1] == 'CREATE TABLESPACE'): list object has no element -1

{
"msg": "The conditional check 'result.stdout_lines[-1] == 'CREATE TABLESPACE'' failed. The error was: error while evaluating conditional (result.stdout_lines[-1] == 'CREATE TABLESPACE'): list object has no element -1"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment