New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added edr parameter to GSLB VServer module #38107

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@scholsey

scholsey commented Mar 29, 2018

SUMMARY

The parameter to change the EDR configuration setting is not currently present in the netscaler_gslb_vserver module. Therefore, would have to use the netscaler_nitro_requests separately to modify it. This change has included the parameter within the module itself.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

netscaler_gslb_vserver

ANSIBLE VERSION
ansible 2.6.0 (devel 9350b5ec22)
ADDITIONAL INFORMATION

@scholsey scholsey changed the title from added edr parameter to gable Vserver module to added edr parameter to GSLB VServer module Mar 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/netscaler/netscaler_gslb_vserver.py:288:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/netscaler/netscaler_gslb_vserver.py:0:0: E309 version_added for new option (edr) should be 2.6. Currently 0.0

click here for bot help

Update netscaler_gslb_vserver.py
removed whitespace from blank line

@ansibot ansibot removed the ci_verified label Mar 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/netscaler/netscaler_gslb_vserver.py:0:0: E309 version_added for new option (edr) should be 2.6. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified label Mar 29, 2018

Update netscaler_gslb_vserver.py
Changed version added to 2.6

@ansibot ansibot removed the ci_verified label Mar 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/netscaler/netscaler_gslb_vserver.py:0:0: E309 version_added for new option (edr) should be 2.6. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified label Mar 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Mar 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/netscaler/netscaler_gslb_vserver.py:0:0: E309 version_added for new option (edr) should be 2.6. Currently 0.0

click here for bot help

@samdoran samdoran removed the needs_triage label Apr 5, 2018

@ansibot ansibot added the stale_ci label Apr 13, 2018

@giorgos-nikolopoulos

This comment has been minimized.

Contributor

giorgos-nikolopoulos commented May 2, 2018

@scholsey

The "edr" option is left out to maintain compatibility with Netscaler 11.1 .

Since compatibility is desired with this version we cannot add this option to the module.

Setting it with the netscaler_nitro_request module is the recommended practice.

@gundalow

This comment has been minimized.

Contributor

gundalow commented May 11, 2018

@giorgos-nikolopoulos Does this need closing then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment