Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
s3_bucket: add encryption capabilities to the module #38538
Add parameters to enable default encryption on a s3 bucket
I've added integration test for AES256. For aws:kms, I have tested it on my account, but since ansible does not provide a module to create kms key I was not able to add it to the integration test suite.
@s-hertel Sorry to bother you once again, but this PR will also need a ci update :(
I have updated the storage-policy.json to reflect the necessary changes. the
Tests in CI were unstable: https://app.shippable.com/github/ansible/ansible/runs/61466/67/tests
I'll restart the tests to see if it occurs again.
@julienvey I tried to create a PR back to you for the review comments here but GitHub failed to show your fork up for some reason. You can check out by changes here https://github.com/wimnat/ansible/tree/s3_encryption
If you could merge these changes that'd be great - I'd love to see this merged.
Also would like to see this added. @wimnat can't you just open a new PR with your branch? Like this https://github.com/ansible/ansible/compare/devel...wimnat:s3_encryption?expand=1