New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: new module: vmware_guest_customization #38583

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@Akasurde
Member

Akasurde commented Apr 11, 2018

SUMMARY

This module adds functionality to manage VM
customization specification.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest_customization.py
test/integration/targets/vmware_guest_customization/aliases
test/integration/targets/vmware_guest_customization/tasks/main.yml

ANSIBLE VERSION
2.6devel
@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 11, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 11, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_customization.py:176:0: anomalous-backslash-in-string Anomalous backslash in string: '\C'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/vmware/vmware_guest_customization.py:176:0: anomalous-backslash-in-string Anomalous backslash in string: '\T'. String constant might be missing an r prefix.
lib/ansible/modules/cloud/vmware/vmware_guest_customization.py:176:0: anomalous-backslash-in-string Anomalous backslash in string: '\W'. String constant might be missing an r prefix.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_customization.py:0:0: E325 argument_spec for "autologon" defines type="bool" but documentation does not

click here for bot help

@Akasurde Akasurde force-pushed the Akasurde:vmware_custom_spec branch Apr 11, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 11, 2018

@Akasurde @bedecarroll @chrrrles @dav1x @garbled1 @jjahns @kamsz @lrivallain @nafpliot-ibm @nerzhul @pdellaert @rhoop @ritzk @stravassac @tchernomax @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde

This comment has been minimized.

Member

Akasurde commented Apr 11, 2018

@pdellaert @tchernomax Could you please review this ?

@ansibot ansibot added the stale_ci label Apr 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 5, 2018

joindomain:
description:
- AD domain to join.
- This parameter is not compatible with C(joinworkgroup).

This comment has been minimized.

@pdellaert

pdellaert May 6, 2018

Contributor

add a mutually_exclusive section

This comment has been minimized.

@Akasurde
description:
- AD domain to join.
- This parameter is not compatible with C(joinworkgroup).
- If set, then C(domainadmin) and C(domainadminpassword) are required parameters.

This comment has been minimized.

@pdellaert

pdellaert May 6, 2018

Contributor

Add a required_together section

This comment has been minimized.

@Akasurde

Akasurde Sep 7, 2018

Member

Done.

lib/ansible/modules/cloud/vmware/vmware_guest_customization.py Outdated
" in given configuration." % new_spec_name)
if not self.module.check_mode:
self.cc_mgr.RenameCustomizationSpec(name=self.spec_name, newName=new_spec_name)
self.module.exit_json(changed=True)

This comment has been minimized.

@pdellaert

pdellaert May 6, 2018

Contributor

You automatically exit on a rename, even while other values might change? Is that required?

Other way could be to do the rename at the end? After reconf has happened if that is necessary

if new_dns_servers and set(current_spec.globalIPSettings.dnsSuffixList) != set(new_dns_suffix):
current_spec.globalIPSettings.dnsSuffixList = new_dns_suffix
reconf_flag = True

This comment has been minimized.

@pdellaert

pdellaert May 6, 2018

Contributor

I'm missing a bunch of items like network info, joindomain etc?

This comment has been minimized.

@Akasurde

Akasurde Sep 7, 2018

Member

I don't have Windows licensed machine to test this.

@pdellaert

This comment has been minimized.

Contributor

pdellaert commented May 6, 2018

Also, on the vm_hostname, is there a way to support the more dynamic hostnames? the facts module (#38588) seems to support it as a fact?

VMware: new module: vmware_guest_customization
This module adds functionality to manage VM
customization specification.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:vmware_custom_spec branch to 40e3da5 Sep 7, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 7, 2018

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

test/integration/targets/vmware_guest_customization/tasks/main.yml:26:2: error syntax error: expected <block end>, but found '<block sequence start>'
test/integration/targets/vmware_guest_customization/tasks/main.yml:46:1: empty-lines too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added ci_verified and removed stale_ci labels Sep 7, 2018

@ansibot ansibot added the stale_ci label Sep 15, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment