Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32910 part2 #38709

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@mmlb
Copy link

mmlb commented Apr 13, 2018

SUMMARY

This PR contains some extra commits needed to fully fix #32910.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module/cloud/packet.net

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Dec 14 2017, 15:51:29) [GCC 6.4.0]
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 13, 2018

mmlb added some commits Apr 13, 2018

cloud/packet: remove bogus mutual exclusions
operating_system is a required parameter, for custom ipxe it should be
set to custom_ipxe. The always_pxe and ipxe_script_url parameters are
only valid when operating_system==custom_ipxe, but they are not mutually
exclusive.

@mmlb mmlb force-pushed the packethost:fix-32910-part2 branch to 6bf9bcc Apr 13, 2018

@mmlb

This comment has been minimized.

Copy link
Author

mmlb commented Apr 19, 2018

@Akasurde should I ping someone to get this merged? whats the process?

@Akasurde

This comment has been minimized.

Copy link
Member

Akasurde commented Apr 20, 2018

@mmlb We need one more person to look into this and then we can proceed further. I would recommend to ping maintainer, in this case @baldwinSPC @t0mk

@t0mk

This comment has been minimized.

Copy link
Contributor

t0mk commented Apr 26, 2018

@baldwinSPC @mmlb @Akasurde I would like to ask to be removed as a maintainer of this module. Could you please remove me?

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.