New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to systematically modify yaml files from ansible. #38841

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@kwoodson
Contributor

kwoodson commented Apr 16, 2018

This pull request adds the ability to systematically modify yaml|json files through ansible.

@maxamillion

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 16, 2018

The test ansible-test sanity --test pylint [explain] failed with 14 errors:

lib/ansible/modules/files/yedit.py:198:28: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:254:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:326:41: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:335:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:353:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:401:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:418:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:481:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:601:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:730:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:743:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:792:31: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:867:0: bad-option-value Bad option value 'redefined-variable-type'
lib/ansible/modules/files/yedit.py:900:36: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/files/yedit.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/files/yedit.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 55, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:17:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:17:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:17:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:17:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:17:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:878:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:1:1: expected module shebang "b'#!/usr/bin/python'" but found: b'#!/usr/bin/env python'

The test ansible-test sanity --test validate-modules [explain] failed with 19 errors:

lib/ansible/modules/files/yedit.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/files/yedit.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E314 No ANSIBLE_METADATA provided
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.') for "separator" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180416T203123') for "backup_ext" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('yaml') for "content_type" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('yaml') for "curr_value_format" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "append" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "backup" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "debug" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "update" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent', 'list']) for "state" does not match the documentation ([])
lib/ansible/modules/files/yedit.py:0:0: E326 Value for "choices" from the argument_spec (['yaml', 'json', 'str']) for "curr_value_format" does not match the documentation ([])
lib/ansible/modules/files/yedit.py:0:0: E326 Value for "choices" from the argument_spec (['yaml', 'json']) for "content_type" does not match the documentation ([])
lib/ansible/modules/files/yedit.py:6:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/files/yedit.py:6:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/files/yedit.py:119:18: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:119:18: error DOCUMENTATION: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@bcoca bcoca removed the needs_triage label Apr 16, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch Apr 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test pylint [explain] failed with 14 errors:

lib/ansible/modules/files/yedit.py:213:28: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:269:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:341:41: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:350:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:368:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:428:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:445:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:508:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:628:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:757:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:770:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:819:31: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:894:0: bad-option-value Bad option value 'redefined-variable-type'
lib/ansible/modules/files/yedit.py:928:36: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/files/yedit.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/files/yedit.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:32:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:32:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:32:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:32:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:32:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:416:61: E231 missing whitespace after ','

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:1:1: expected module shebang "b'#!/usr/bin/python'" but found: b'#!/usr/bin/env python'

The test ansible-test sanity --test validate-modules [explain] failed with 22 errors:

lib/ansible/modules/files/yedit.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/files/yedit.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/files/yedit.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/files/yedit.py:0:0: E307 version_added should be 2.6. Currently 0.0
lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E314 No ANSIBLE_METADATA provided
lib/ansible/modules/files/yedit.py:0:0: E322 "edits" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180417T143604') for "backup_ext" does not match the documentation ('.orig')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('yaml') for "content_type" does not match the documentation ('dict')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('yaml') for "curr_value_format" does not match the documentation ('False')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (False) for "backup" does not match the documentation (True)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "content" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "curr_value" does not match the documentation ('False')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "index" does not match the documentation (False)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "src" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "append" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "backup" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "debug" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "update" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E326 Value for "choices" from the argument_spec (['yaml', 'json']) for "content_type" does not match the documentation ([])
lib/ansible/modules/files/yedit.py:21:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/files/yedit.py:21:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified label Apr 17, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch Apr 17, 2018

@ansibot ansibot removed the ci_verified label Apr 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test pylint [explain] failed with 14 errors:

lib/ansible/modules/files/yedit.py:233:28: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:289:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:361:41: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:370:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:388:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:448:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:465:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:528:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:648:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:777:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:790:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:839:31: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:914:0: bad-option-value Bad option value 'redefined-variable-type'
lib/ansible/modules/files/yedit.py:948:36: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test boilerplate [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:436:61: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 10 errors:

lib/ansible/modules/files/yedit.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got 1.1
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180417T152046') for "backup_ext" does not match the documentation ('.orig')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "content" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "curr_value" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "edits" does not match the documentation (['None'])
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "src" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E325 argument_spec for "backup" defines type="bool" but documentation does not
lib/ansible/modules/files/yedit.py:0:0: E327 Default value from the documentation ('None') is not compatible with type 'int' defined in the argument_spec

click here for bot help

@ansibot ansibot added the ci_verified label Apr 17, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch Apr 17, 2018

@ansibot ansibot removed the ci_verified label Apr 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test pylint [explain] failed with 13 errors:

lib/ansible/modules/files/yedit.py:233:28: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:361:41: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:370:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:388:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:448:39: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:465:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:528:33: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:648:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:777:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:790:37: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:839:31: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/files/yedit.py:914:0: bad-option-value Bad option value 'redefined-variable-type'
lib/ansible/modules/files/yedit.py:948:36: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:210:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/files/yedit.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got 1.1
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180417T165258') for "backup_ext" does not match the documentation ('.<datestr>')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "content" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "curr_value" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "edits" does not match the documentation (['None'])
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "src" does not match the documentation ('None')
lib/ansible/modules/files/yedit.py:0:0: E327 Default value from the documentation ('None') is not compatible with type 'int' defined in the argument_spec

click here for bot help

@ansibot ansibot added the ci_verified label Apr 17, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch 2 times, most recently Apr 17, 2018

@ansibot ansibot removed the ci_verified label Apr 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:207:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:207:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:207:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:207:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:207:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/files/yedit.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/files/yedit.py:0:0: E305 DOCUMENTATION.options.index.type: not a valid value for dictionary value @ data['options']['index']['type']. Got 'int'
lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180417T183939') for "backup_ext" does not match the documentation ('.<datestr>')
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "curr_value" does not match the documentation ('None')

click here for bot help

@ansibot ansibot added the ci_verified label Apr 17, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch Apr 17, 2018

@ansibot ansibot removed the ci_verified label Apr 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 17, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:191:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:191:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:191:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:191:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:191:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/files/yedit.py:0:0: E312 No RETURN provided
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180417T203518') for "backup_ext" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec (None) for "curr_value" does not match the documentation ('None')

click here for bot help

@ansibot ansibot added the ci_verified label Apr 17, 2018

lib/ansible/modules/files/yedit.py Outdated
ANSIBLE_METADATA = {'metadata_version': '1.1',
'status': ['preview'],
'supported_by': 'core'}

This comment has been minimized.

@gundalow

gundalow Apr 18, 2018

Contributor

community, no core here please.

This comment has been minimized.

@kwoodson

kwoodson Apr 18, 2018

Contributor

I was copying what another file had in it. I'll update.

lib/ansible/modules/files/yedit.py Outdated
DOCUMENTATION = '''
---
module: yedit

This comment has been minimized.

@gundalow

gundalow Apr 18, 2018

Contributor

Bike shed: would be good if this included yaml in its name.

This comment has been minimized.

@kwoodson

kwoodson Apr 18, 2018

Contributor

yedit was chosen for yaml - edit. It also handles json since it is a subset of yaml. Basically modifying structured yaml/json.

pass
# pylint: disable=too-many-public-methods,too-many-instance-attributes

This comment has been minimized.

@gundalow

gundalow Apr 18, 2018

Contributor

RETURN block missing

This comment has been minimized.

@kwoodson

kwoodson Apr 18, 2018

Contributor

I'm not sure what this returns to. I'll look at some other modules to determine what this refers to.

This comment has been minimized.

@kwoodson

kwoodson Apr 18, 2018

Contributor

Updated.

@kwoodson kwoodson force-pushed the kwoodson:yedit branch Apr 18, 2018

@kwoodson

This comment has been minimized.

Contributor

kwoodson commented Apr 18, 2018

@gundalow, Thanks. Addressed the comments. The bot states that it cannot find yaml. How do we handle this failure? I am using PyYaml or ruamel.yaml.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 18, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:213:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:213:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:213:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:213:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:213:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:179:7: E225 missing whitespace around operator

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/files/yedit.py:0:0: E324 Value for "default" from the argument_spec ('.20180418T151332') for "backup_ext" does not match the documentation (None)
lib/ansible/modules/files/yedit.py:180:6: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:180:6: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@kwoodson kwoodson force-pushed the kwoodson:yedit branch 4 times, most recently Apr 18, 2018

@ansibot ansibot removed the ci_verified label Apr 18, 2018

@kwoodson kwoodson force-pushed the kwoodson:yedit branch to 4841360 Apr 18, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Apr 18, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:179:7: E225 missing whitespace around operator

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:180:6: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:180:6: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified label Apr 18, 2018

@ansibot ansibot added the stale_ci label Apr 26, 2018

@kwoodson

This comment has been minimized.

Contributor

kwoodson commented Apr 30, 2018

@gundalow updated with your requested comments.

@kwoodson

This comment has been minimized.

Contributor

kwoodson commented Jul 18, 2018

@gundalow, any updates on this?

@maxamillion

This comment has been minimized.

Contributor

maxamillion commented Nov 27, 2018

ping @gundalow

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/files/yedit.py:179:6: bad-whitespace Exactly one space required around assignment RETURN='''r       ^
lib/ansible/modules/files/yedit.py:207:4: useless-import-alias Import alias does not rename original package

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named yaml

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ImportError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:209:0: ModuleNotFoundError: No module named 'yaml'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:179:7: E225 missing whitespace around operator

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/files/yedit.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['Kenny Woodson <kwoodson@redhat.com>']
lib/ansible/modules/files/yedit.py:0:0: E307 version_added should be 2.8. Currently 2.6
lib/ansible/modules/files/yedit.py:180:6: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/files/yedit.py:180:6: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the stale_ci label Nov 27, 2018

@ansibot ansibot added the stale_ci label Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment