Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Generalize connection command running and I/O for all connection types #38976

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

[WIP] Generalize connection command running and I/O for all connection types #38976

wants to merge 1 commit into from
+343 −396

Conversation

jimi-c
Copy link
Member

@jimi-c jimi-c commented Apr 18, 2018

This is the first pass at trying to get the guts of the I/O handling moved from being ssh-specific to a more generalized implementation other connection plugins can use to take advantage of the better state handling for become escalations.

@jimi-c
Copy link
Member Author

jimi-c commented Apr 18, 2018

!bot_skip

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2018

@jimi-c Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 18, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/plugins/connection/__init__.py:287:18: undefined-variable Undefined variable 'AnsibleConnectionFailure'
lib/ansible/plugins/connection/__init__.py:342:30: undefined-variable Undefined variable 'errno'
lib/ansible/plugins/connection/__init__.py:424:115: undefined-variable Undefined variable 'to_native'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/connection/__init__.py:318:161: E501 line too long (169 > 160 characters)
lib/ansible/plugins/connection/__init__.py:328:161: E501 line too long (175 > 160 characters)

click here for bot help

@jimi-c jimi-c force-pushed the move_bare_run_to_connection_base branch from 4f57f8a to 550a201 Compare April 19, 2018 14:48
@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/plugins/connection/__init__.py:287:18: undefined-variable Undefined variable 'AnsibleConnectionFailure'
lib/ansible/plugins/connection/__init__.py:342:30: undefined-variable Undefined variable 'errno'
lib/ansible/plugins/connection/__init__.py:424:115: undefined-variable Undefined variable 'to_native'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/connection/__init__.py:318:161: E501 line too long (169 > 160 characters)
lib/ansible/plugins/connection/__init__.py:328:161: E501 line too long (175 > 160 characters)

click here for bot help

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2021

@jimi-c This pullrequest is waiting for you to provide the requested data in the description. Please edit the description or the pullrequest will be closed.

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 9, 2021
@mkrizek
Copy link
Contributor

mkrizek commented Feb 9, 2021

bot_skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. pre_azp This PR was last tested before migration to Azure Pipelines. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimi-c @ansibot @mkrizek