Fixed error handling in github_issue module #39652

Akasurde · 2018-05-03T04:17:35Z

SUMMARY

Due to recent changes in github3.py library module stopped working.
This fix adds extra error handling for new changes in library.

Fixes: #39627

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/source_control/github_issue.py

ANSIBLE VERSION

2.6devel

ansibot · 2018-05-03T04:23:04Z

cc @Akasurde
click here for bot help

ansibot · 2018-05-03T04:56:31Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:1382:1: A102 Remove since "lib/ansible/modules/source_control/github_issue.py" passes "E324" test

click here for bot help

ansibot · 2018-05-03T05:19:05Z

cc @mattclay
click here for bot help

mattclay · 2018-05-03T14:10:38Z

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/63626/32/console

RuntimeError: cryptography requires setuptools 18.5 or newer, please upgrade to a newer version of setuptools

mattclay · 2018-07-27T16:24:12Z

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/76179/37/tests

Akasurde · 2018-07-28T04:10:43Z

@mattclay how do I skip tests for linux/centos6/1 and linux/opensuse42.3/1 ?

mattclay · 2018-07-28T06:55:40Z

Why do the tests need to be skipped on those platforms? If it's due to versions of available packages, use feature detection to skip tests when the requirements are not available instead of hard coding the known platforms.

If the issue is in fact with the platforms themselves, they will need to be skipped in the test playbook by looking at the distribution and version.

Akasurde · 2019-04-11T04:04:56Z

@mattclay Can you please take another look into this ? Thanks in advance.

mattclay · 2019-04-16T17:24:48Z

test/integration/targets/github_issue/tasks/main.yml

+
+  # CentOS 6 and OpenSuSE 42 does not support installation of latest setuptools which is required for requests and github3.py
+  # Skipping this testcase using following
+  when: not ((ansible_os_family == 'Suse' and ansible_distribution_major_version | int == 42 ) or (ansible_os_family == 'RedHat' and ansible_distribution_major_version | int == 6))


It looks like this block and conditional are no longer needed.

Due to recent changes in github3.py library module stopped working. This fix adds extra error handling for new changes in library. Fixes: ansible#39627 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde · 2019-05-15T05:59:07Z

rebuild_merge

* Fixed error handling in github_issue module Due to recent changes in github3.py library module stopped working. This fix adds extra error handling for new changes in library. Fixes: ansible#39627 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Check version Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Refactor github_issue Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde mentioned this pull request May 3, 2018

Failing integration test github_issue #39627

Closed

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 3, 2018

jborean93 removed the needs_triage Needs a first human triage before being processed. label May 3, 2018

Akasurde force-pushed the i39627 branch from 6ec601c to 7f05bf1 Compare May 3, 2018 05:12

ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels May 3, 2018

Akasurde force-pushed the i39627 branch 2 times, most recently from 09cd71b to 050ca00 Compare May 3, 2018 07:17

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 3, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 11, 2018

ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 19, 2018

Akasurde force-pushed the i39627 branch from 050ca00 to fe7a4cd Compare July 27, 2018 10:31

ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 27, 2018

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 27, 2018

ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 10, 2019

Akasurde force-pushed the i39627 branch 2 times, most recently from acf9afa to c6cfbd5 Compare April 10, 2019 09:39

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 10, 2019

mattclay requested changes Apr 16, 2019

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 16, 2019

Akasurde added 3 commits April 20, 2019 11:36

Fixed error handling in github_issue module

8d74438

Due to recent changes in github3.py library module stopped working. This fix adds extra error handling for new changes in library. Fixes: ansible#39627 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Check version

e869449

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Refactor github_issue

b3be296

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

Akasurde force-pushed the i39627 branch from cd0508f to b3be296 Compare April 20, 2019 06:14

ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Apr 30, 2019

Akasurde requested a review from mattclay May 1, 2019 05:29

mattclay approved these changes May 14, 2019

View reviewed changes

ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 15, 2019

ansibot merged commit 5ef2c53 into ansible:devel May 15, 2019

ansible locked and limited conversation to collaborators Aug 5, 2019

Akasurde deleted the i39627 branch August 22, 2023 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed error handling in github_issue module #39652

Fixed error handling in github_issue module #39652

Akasurde commented May 3, 2018

ansibot commented May 3, 2018

ansibot commented May 3, 2018

ansibot commented May 3, 2018

mattclay commented May 3, 2018

mattclay commented Jul 27, 2018

Akasurde commented Jul 28, 2018

mattclay commented Jul 28, 2018

Akasurde commented Apr 11, 2019

mattclay Apr 16, 2019

Akasurde commented May 15, 2019

Fixed error handling in github_issue module #39652

Fixed error handling in github_issue module #39652

Conversation

Akasurde commented May 3, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ansibot commented May 3, 2018

ansibot commented May 3, 2018

ansibot commented May 3, 2018

mattclay commented May 3, 2018

mattclay commented Jul 27, 2018

Akasurde commented Jul 28, 2018

mattclay commented Jul 28, 2018

Akasurde commented Apr 11, 2019

mattclay Apr 16, 2019

Choose a reason for hiding this comment

Akasurde commented May 15, 2019