Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensu_client custom attributes #39682

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@rwha
Copy link

rwha commented May 3, 2018

SUMMARY

Adding a custom parameter to sensu_client for custom client attributes:

https://docs.sensu.io/sensu-core/1.3/reference/clients/#custom-attributes

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sensu_client

ANSIBLE VERSION
ansible 2.5.2
  config file = /home/x/repos/y/ansible.cfg
  configured module search path = [u'/home/x/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Apr 16 2018, 20:08:15) [GCC 7.3.1 20180406]

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented May 3, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented May 3, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "deregister" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "keepalives" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "safe_mode" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])
lib/ansible/modules/monitoring/sensu_client.py:87:7: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:87:7: error DOCUMENTATION: syntax error: expected <block end>, but found '?'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented May 3, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "deregister" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "keepalives" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "safe_mode" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])
lib/ansible/modules/monitoring/sensu_client.py:87:7: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:87:7: error DOCUMENTATION: syntax error: expected <block end>, but found '?'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jun 14, 2018

@rwha this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@rwha rwha force-pushed the rwha:SENSU_CLIENT_CUSTOM_ATTRIBUTES branch Jun 14, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jun 14, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "deregister" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "keepalives" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E325 argument_spec for "safe_mode" defines type="bool" but documentation does not
lib/ansible/modules/monitoring/sensu_client.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])
lib/ansible/modules/monitoring/sensu_client.py:87:7: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:87:7: error DOCUMENTATION: syntax error: expected <block end>, but found '?'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Jun 14, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/sensu_client.py:0:0: E309 version_added for new option (custom) should be 2.7. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified label Jun 14, 2018

@rwha rwha force-pushed the rwha:SENSU_CLIENT_CUSTOM_ATTRIBUTES branch to 4350da8 Jun 14, 2018

@jaredledvina
Copy link

jaredledvina left a comment

For what my review might be worth, this looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.