Fix to output string of items rather than unicode of items.

[sean-m-sullivan]

SUMMARY

Fix to output string of items rather than unicode of items.

While looking into callback modules and seeing outputs, I came accross this anomoly. Ansible normally outputs in strings, and not unicode, however when using with_items it outputs the list in a unicode format.

After searching, I found that converting the list within the get_items method of initi.py fixed this.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

initi.py

ANSIBLE VERSION

ansible 2.5.2
  config file = /home/excalibrax/Dropbox/LinuxDocs/projects/ansible_testing/callback_plugins_git/testing_role/ansible.cfg
  configured module search path = [u'/home/excalibrax/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

ADDITIONAL INFORMATION

This effects output to the screen via the callback modules, and should not effect any existing roles or aspects of ansible.
Code to reproduce:

  - name: add packages
    yum:
      name: "{{ item }}"
      state: present
    with_items:
       - httpd
       - perl

Output changes:

Original output:
ok: [172.16.0.2] => (item=[u'httpd', u'perl'])
changed: [172.16.0.3] => (item=[u'httpd', u'perl'])
New output:
ok: [172.16.0.2] => (item=['httpd', 'perl'])
changed: [172.16.0.3] => (item=['httpd', 'perl'])

[sean-m-sullivan]

I'm unsure what has failed, but would appreciate some feedback on the code and/or idea of the change. There might be another method that would be more acceptable?.

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/callback/__init__.py:230:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/callback/__init__.py:230:9: E266 too many leading '#' for block comment
lib/ansible/plugins/callback/__init__.py:230:71: W291 trailing whitespace

click here for bot help

[bcoca]

A couple of things:

• you are assuming item is a list, it can be any type
• str() is not a good function across versions of python, that is why we have to_text and to_native

[ansibot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/callback/__init__.py:230:9: E265 block comment should start with '# '

click here for bot help

[mattclay]

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/64347/3/tests

CI failure in integration tests likely due to this warning:

2018-05-08 18:34:08 [WARNING]: Failure using method (v2_runner_item_on_ok) in callback plugin
2018-05-08 18:34:08 (<ansible.plugins.callback.default.CallbackModule object at 0x3909450>): 'int'
2018-05-08 18:34:08 object is not iterable