Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that recurse only applies to state=directory #40222

Merged
merged 1 commit into from Sep 12, 2018
Merged

Make it clear that recurse only applies to state=directory #40222

merged 1 commit into from Sep 12, 2018

Conversation

Nothing4You
Copy link
Contributor

+label: docsite_pr

SUMMARY

This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

file

ANSIBLE VERSION
ansible 2.5.2
  config file = /home/user/tmp/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Apr 16 2018, 20:08:15) [GCC 7.3.1 20180406]

@Nothing4You
Make it clear that recurse only applies to state=directory
556489e 
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

+label: docsite_pr
@Nothing4You Nothing4You mentioned this pull request May 16, 2018
Closed
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 16, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 17, 2018
@jborean93 jborean93 requested a review from abadger May 17, 2018 03:51
@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 25, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label May 26, 2018
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Jun 11, 2018
@acozine
Copy link
Contributor

acozine commented Sep 12, 2018

@Nothing4You thanks for contributing this change, and sorry the PR sat open for a while. This change does clarify the documentation. We appreciate your interest in Ansible and in clear documentation!

@acozine
Copy link
Contributor

acozine commented Sep 12, 2018

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 12, 2018
@ansibot ansibot merged commit ea8924f into ansible:devel Sep 12, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nothing4You @acozine @dagwieers @ansibot @jborean93