New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBoss namespace and jboss_resource #40320

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@jairojunior
Member

jairojunior commented May 17, 2018

This is an attempt to split PR #39524 into multiple PR's according to recommendations.

SUMMARY

This PR is composed of shared code for three remote management module for JBoss: jboss_deployment, jboss_resource and jboss_command. Only jboss_resource is inclued in this PR.

The rationale behind using Management API as opposed to traditional JBoss-CLI [1] approach is to reduce the burden of the module user to Manage JBoss's resources by introducing a declarative approach that is idempotent by nature (at least for jboss_deployment and jboss_resource).

There is already a jboss module in web_infrastructure [2] to perform deploys, but it's limited to standalone mode and it leverages deployment scanner, so it basically copy the file to deployment directory, hence it did not provide any feedback for module users regarding deployment success or failure.

I developed a showcase role [3] to aid in the development of these modules. There are a few examples there and it's fully functional.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

modules/web_infrastructure/jboss/jboss_resource

ANSIBLE VERSION
2.7.0

[1] https://github.com/jairojunior/wildfly-ha-tcpgossip-vagrant-puppet/blob/master/wildfly-rolling-deployment.yml#L24

[2] http://docs.ansible.com/ansible/jboss_module.html

[3] https://github.com/jairojunior/ansible-role-jboss

CORE CHANGES

This PR changes open_url behavior to use a user provided Authentication Realm. A better way to handle this would be to guess this realm based on the first request, as other libraries do.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 7, 2018

@jairojunior this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit and removed stale_ci labels Jul 7, 2018

@jairojunior jairojunior force-pushed the jairojunior:jboss_namespace branch Jul 7, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 7, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/web_infrastructure/jboss/jboss_resource.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@jairojunior jairojunior force-pushed the jairojunior:jboss_namespace branch 2 times, most recently Jul 7, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Jul 16, 2018

@ansibot ansibot added the stale_ci label Jul 17, 2018

@jairojunior jairojunior force-pushed the jairojunior:jboss_namespace branch Aug 4, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 4, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/jboss_resource/aliases:0:0: missing alias `shippable/posix/group[1-3]` or `unsupported`

click here for bot help

@ansibot ansibot added the ci_verified label Aug 4, 2018

@jairojunior jairojunior force-pushed the jairojunior:jboss_namespace branch Aug 4, 2018

@ansibot ansibot removed the ci_verified label Aug 4, 2018

@jairojunior jairojunior force-pushed the jairojunior:jboss_namespace branch Aug 5, 2018

@ansibot ansibot added core_review and removed needs_revision labels Aug 5, 2018

@jairojunior

This comment has been minimized.

Member

jairojunior commented Aug 6, 2018

urls code is here: #43681

@jairojunior

This comment has been minimized.

Member

jairojunior commented Aug 6, 2018

@jhoekx Since you're the current author of existing jboss module in the codebase. Your review would be much appreciated.

@gundalow

This comment has been minimized.

Contributor

gundalow commented Aug 6, 2018

@wbrefvem @jairojunior @Wolfant As members of the JBoss working group, could you please review this PR

@gundalow

This comment has been minimized.

Contributor

gundalow commented Dec 3, 2018

@wbrefvem @jairojunior @Wolfant Any chance you could review this JBoss PR, thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment