New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module to manage replication subnet groups for AWS Database Migration Service #40368

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@slapula
Contributor

slapula commented May 17, 2018

SUMMARY

This is my first pull request of several to add support for AWS Database Migration Service. This module manages the replication subnet groups in the spirit of rds_subnet_group and redshift_subnet_group. It's a pretty simple module in terms of functionality. One omission however. I did not include support for adding and removing tags since AWS' documentation around replication subnet group ARNs is lacking (and I haven't been able to figure out how to properly form them myself) and you need the ARN to use the API calls.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dms_subnet_group

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/Users/asmith/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/asmith/.pyenv/versions/2.7.13/lib/python2.7/site-packages/ansible
  executable location = /Users/asmith/.pyenv/versions/2.7.13/bin/ansible
  python version = 2.7.13 (default, Sep  8 2017, 15:16:38) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
@mattclay

This comment has been minimized.

Member

mattclay commented May 18, 2018

CI failure in integration tests due to traceback:

https://app.shippable.com/github/ansible/ansible/runs/66096/67/tests

Traceback (most recent call last):
  File "/tmp/ansible_qexercul/ansible_module_ec2_vpc_net.py", line 180, in vpc_exists
    matching_vpcs = vpc.describe_vpcs(Filters=[{'Name': 'tag:Name', 'Values': [name]}, {'Name': 'cidr-block', 'Values': cidr_block}])['Vpcs']
  File "/tmp/ansible_qexercul/ansible_modlib.zip/ansible/module_utils/aws/core.py", line 215, in deciding_wrapper
    return unwrapped(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python3.6/dist-packages/botocore/client.py", line 612, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (AuthFailure) when calling the DescribeVpcs operation: AWS was not able to validate the provided access credentials

@ansibot ansibot removed the ci_verified label May 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 20, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@mattclay

This comment has been minimized.

Member

mattclay commented May 21, 2018

@s-hertel Is this something we can support testing in CI instead of marking it unsupported?

@@ -0,0 +1,3 @@
cloud/aws
unsupported
unstable

This comment has been minimized.

@mattclay

mattclay May 21, 2018

Member

New tests should not be marked unstable. Also, the tests should only be marked unsupported if we cannot add permissions to our CI system to run the tests or the tests will be too slow to be used in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment