New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to define tags for elasticache #40432

Open
wants to merge 31 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@memo42
Contributor

memo42 commented May 19, 2018

SUMMARY

Added the ability to add tags. Fixes #24214

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elasticache

ANSIBLE VERSION
ansible 2.5.1
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/mo/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

ADDITIONAL INFORMATION

new version of #27944


@ansibot

This comment has been minimized.

Contributor

ansibot commented May 19, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:258:0: syntax-error inconsistent use of tabs and spaces in indentation (<string>, line 258)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:258:29: SyntaxError: if self.zone is not None:

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:258:29: SyntaxError: if self.zone is not None:

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:258:29: SyntaxError: if self.zone is not None:

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 3.5 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (elasticache.py, line 258) (in /root/ansible/test/runner/.tox/minimal-py35/bin/importer.py:82)
lib/ansible/modules/cloud/amazon/elasticache.py:258:29: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test import --python 3.6 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (elasticache.py, line 258) (in /root/ansible/test/runner/.tox/minimal-py36/bin/importer.py:82)
lib/ansible/modules/cloud/amazon/elasticache.py:258:29: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test import --python 3.7 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: TabError: inconsistent use of tabs and spaces in indentation (elasticache.py, line 258) (in /root/ansible/test/runner/.tox/minimal-py37/bin/importer.py:82)
lib/ansible/modules/cloud/amazon/elasticache.py:258:29: TabError: inconsistent use of tabs and spaces in indentation

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/elasticache/aliases:0:0: missing alias `posix/ci/cloud/group[1-5]/aws` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:258:3: E101 indentation contains mixed spaces and tabs
lib/ansible/modules/cloud/amazon/elasticache.py:258:3: W191 indentation contains tabs

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: E401 Python SyntaxError while parsing module
test/sanity/validate-modules/ignore.txt:91:1: A102 Remove since "lib/ansible/modules/cloud/amazon/elasticache.py" passes "E324" test
test/sanity/validate-modules/ignore.txt:92:1: A102 Remove since "lib/ansible/modules/cloud/amazon/elasticache.py" passes "E326" test

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:258:29: python-syntax-error inconsistent use of tabs and spaces in indentation (<unknown>, line 258)

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 19, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/elasticache/aliases:0:0: missing alias `posix/ci/cloud/group[1-5]/aws` or `unsupported`

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: E325 argument_spec for "purge_tags" defines type="bool" but documentation does not
lib/ansible/modules/cloud/amazon/elasticache.py:0:0: E327 Default value from the documentation ('none') is not compatible with type 'dict' defined in the argument_spec

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels May 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 19, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elasticache.py:0:0: E305 DOCUMENTATION.options.tags.type: not a valid value for dictionary value @ data['options']['tags']['type']. Got 'dict'

click here for bot help

@memo42 memo42 force-pushed the memo42:devel branch to 05208a4 Jul 18, 2018

@ansibot ansibot removed the stale_ci label Jul 18, 2018

@ansibot ansibot added the stale_ci label Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment