New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module for managing AWS Data Migration Service endpoints #40459

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@slapula
Contributor

slapula commented May 20, 2018

SUMMARY

This is my second pull request of several to add support for AWS Database Migration Service. This module manages DMS endpoints. I'm currently on the fence about working in the test_connection API call to verify valid and working endpoints but I'm not sure if that should be included in the scope of this module's role.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dms_endpoint

ANSIBLE VERSION
ansible 2.4.1.0
  config file = None
  configured module search path = [u'/Users/asmith/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/asmith/.pyenv/versions/2.7.13/lib/python2.7/site-packages/ansible
  executable location = /Users/asmith/.pyenv/versions/2.7.13/bin/ansible
  python version = 2.7.13 (default, Sep  8 2017, 15:16:38) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
@ansibot

This comment has been minimized.

Contributor

ansibot commented May 20, 2018

The test ansible-test sanity --test docs-build [explain] failed with 108 errors:

docs/docsite/rst/modules/dms_endpoint_module.rst:712:0: explicit-markup-missing-blank-line: Explicit markup ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:714:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:716:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:719:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:720:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:723:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:725:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:726:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:728:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:729:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:731:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:733:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:736:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:739:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:743:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:745:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:746:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:748:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:749:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:751:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:755:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:758:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:762:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:764:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:765:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:767:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:768:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:770:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:774:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:777:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:781:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:783:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:784:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:786:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:787:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:789:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:793:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:794:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:797:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:800:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:801:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:804:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:805:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:807:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:809:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:810:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:812:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:816:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:819:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:820:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:821:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:824:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:826:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:828:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:829:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:831:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:835:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:838:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:842:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:844:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:846:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:847:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:849:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:853:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:856:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:860:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:862:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:864:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:865:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:867:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:873:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:874:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:877:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:880:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:884:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:886:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:888:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:889:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:891:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:895:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:896:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:899:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:902:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:906:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:908:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:910:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:911:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:913:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:917:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:920:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:924:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:926:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:928:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:929:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:931:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:935:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:938:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:942:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:944:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:946:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:947:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:949:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:951:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:953:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:954:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:957:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:960:0: definition-list-missing-blank-line: Definition list ends without a blank line; unexpected unindent.
docs/docsite/rst/modules/dms_endpoint_module.rst:963:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.

click here for bot help

slapula added some commits May 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented May 20, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added the stale_ci label Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment