New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add module to manage NFSv4 ACLs #40671

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@victorhahncastell

victorhahncastell commented May 24, 2018

SUMMARY

As it seems Ansible does not provide native support for NFSv4 ACLs yet I quickly wrote this one for my current customer based on the existing Posix ACL module. I'm not sure if the project is looking to go down this route or if a common ACL module autodetecting the correct protocol would be more desirable.

In any case, I'm submitting this as a draft to start the discussion.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

acl_nfs4

ANSIBLE VERSION
ansible 2.5.1
  config file = None
  configured module search path = [u'/home/victor/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Dec 14 2017, 10:27:37) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]
ADDITIONAL INFORMATION

victorhahncastell added some commits Apr 10, 2018

[acl_nfs4] Initial commit for module acl_nfs4
This module is derived from the acl module which deals with POSIX ACLs and tries to provide a compatible interface as much as possible.
[acl_nfs4] Fix typo
(and a rather embarrassing one at that)
@ansibot

This comment has been minimized.

Contributor

ansibot commented May 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/files/acl_nfs4.py:62:161: E501 line too long (250 > 160 characters)
lib/ansible/modules/files/acl_nfs4.py:83:161: E501 line too long (192 > 160 characters)
lib/ansible/modules/files/acl_nfs4.py:225:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/files/acl_nfs4.py:231:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/files/acl_nfs4.py:242:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/files/acl_nfs4.py:0:0: E305 DOCUMENTATION.options.ace_type.type: not a valid value for dictionary value @ data['options']['ace_type']['type']. Got 'str'
lib/ansible/modules/files/acl_nfs4.py:0:0: E305 DOCUMENTATION.options.transmission_format.type: not a valid value for dictionary value @ data['options']['transmission_format']['type']. Got 'str'
lib/ansible/modules/files/acl_nfs4.py:0:0: E322 "entry" is listed in the argument_spec, but not documented in the module

click here for bot help

@samdoran samdoran changed the title from Feature/nfs4 acl to [WIP] Add module to manage NFSv4 ACLs May 24, 2018

@samdoran samdoran removed the needs_triage label May 24, 2018

@ansibot ansibot added the WIP label May 24, 2018

@ansibot ansibot added the stale_ci label Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment