Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding module to manage both trusted and threat IP sets in AWS Guardduty #40851
This is a module to manage IP lists in AWS GuardDuty. It handles both IP sets (Amazon's name not mine, here I'm referring to these as trusted IP sets) and threat intel sets. The integration tests utilize the
CI failure in integration tests:
referenced this pull request
Jul 2, 2018
Thanks @s-hertel ! Bear with me, I am aware that there are a number of improvements I can make across the board with my open PRs. There are things I learned while working on my later PRs that I should and will include in my earlier PRs. If you see something say something but keep in mind that I am going to be circling back on all of them to make sure they are as merge ready as they can be.
Please add in retries (aws_retry should make this pretty easy).